[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Forward change type to model
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-17 21:17:20
Message-ID: 20100517211720.4871.81507 () localhost
[Download RAW message or body]



> On 2010-05-17 21:08:05, Johannes Simon wrote:
> > Besides the two minor changes mentioned in my inline comments, the patch looks \
> > good to me. I'll actually go ahead and use it in KChart::Layout as the current \
> > change-type-check is a bit ugly.

Cool, I'll commit it then :)


> On 2010-05-17 21:08:05, Johannes Simon wrote:
> > trunk/koffice/libs/flake/KoShapeContainerDefaultModel.cpp, line 146
> > <http://reviewboard.kde.org/r/4011/diff/1/?file=26927#file26927line146>
> > 
> > Since this is the default implementation, and it deliberately does nothing, maybe \
> > add Q_UNUSED() here for both parameters?

The unused parameters have instead been removed to avoid any warnings, so an Q_UNUSED \
is not needed.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4011/#review5704
-----------------------------------------------------------


On 2010-05-17 20:48:51, Thomas Zander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4011/
> -----------------------------------------------------------
> 
> (Updated 2010-05-17 20:48:51)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Also forward the change type enum to the model.
> 
> Since the caller always has it it seems kind of silly not to
> forward it as it can be used well to avoid unneeded work in implementations.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kchart/shape/Layout.h 1127864 
> trunk/koffice/kchart/shape/Layout.cpp 1127864 
> trunk/koffice/krita/ui/flake/kis_shape_selection_model.h 1127864 
> trunk/koffice/krita/ui/flake/kis_shape_selection_model.cpp 1127864 
> trunk/koffice/libs/flake/KoShapeContainer.cpp 1127864 
> trunk/koffice/libs/flake/KoShapeContainerDefaultModel.h 1127864 
> trunk/koffice/libs/flake/KoShapeContainerDefaultModel.cpp 1127864 
> trunk/koffice/libs/flake/KoShapeContainerModel.h 1127864 
> trunk/koffice/libs/flake/SimpleShapeContainerModel.h 1127864 
> trunk/koffice/libs/flake/tests/MockShapes.h 1127864 
> trunk/koffice/libs/kotext/KoTextShapeContainerModel.h 1127864 
> trunk/koffice/libs/kotext/KoTextShapeContainerModel.cpp 1127864 
> trunk/koffice/plugins/dockers/shapeselector/FolderShapeModel.h 1127864 
> trunk/koffice/plugins/dockers/shapeselector/FolderShapeModel.cpp 1127864 
> 
> Diff: http://reviewboard.kde.org/r/4011/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]