[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: 'Combined characters' support for KWord
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-05-13 9:23:49
Message-ID: 20100513092349.15906.80665 () localhost
[Download RAW message or body]



> On 2010-05-13 04:27:06, Thorsten Zachmann wrote:
> > /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp, line 864
> > <http://reviewboard.kde.org/r/3701/diff/5/?file=26473#file26473line864>
> > 
> > Creating a formula shape to load it then by the formula shape looks very wrong to \
> > me. Would it be possible to load the needed data in KoTextLoader as it is done \
> > now and then set it directly on the formula shape without going over loading.
> 
> Miroslav Nohaj wrote:
> Yes, it could be done also like that, but this is a less invasive way to do it - \
> just let the formula shape do it like it does it for the normal data. Would this \
> approach be such an issue that it would need to be reworked?

I like Thorstens idea. Shape plugins can be created by the factory with pre-set \
properties so it should not become invasive. See \
http://www.koffice.org/developer/apidocs/libs-flake/classKoShapeFactoryBase.html#3699185b455f9bbddfaf499c1cc2bc06
 where you can provide the "properties" parameter with the data you want.  The \
implementation of the factory inside the formula flake plugin may have to be extended \
to support those.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3701/#review5641
-----------------------------------------------------------


On 2010-05-11 14:08:12, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3701/
> -----------------------------------------------------------
> 
> (Updated 2010-05-11 14:08:12)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This code adds displaying of combined characters into KWord using KoFormulaShape by \
> generating appropriate MathML code. This is the 1st version, because currently the \
> KoFormulaShape ignores the width and height attributes and thus the displayed size \
> is always 50pt by 50pt (will have to check the KoFormulaShape deeper) and thus the \
> final size of the combined characters is not as small as a regular character (but \
> the patch as a whole is 95% complete). Please take a look and post comments if you \
> have some. 
> 
> Diffs
> -----
> 
> /trunk/koffice/kformula/flake/KoFormulaShape.h 1125472 
> /trunk/koffice/kformula/flake/KoFormulaShape.cpp 1125472 
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1125472 
> /trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1125472 
> /trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1125472 
> 
> Diff: http://reviewboard.kde.org/r/3701/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]