[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: msword-odf filter: support for floating pictures
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-05-12 7:52:01
Message-ID: 20100512075201.11421.77914 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3949/#review5619
-----------------------------------------------------------

Ship it!


- Casper


On 2010-05-11 16:32:27, Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3949/
> -----------------------------------------------------------
> 
> (Updated 2010-05-11 16:32:27)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> patch description:
> 
> * using simpleParser and pole storage from libmso to parse floating pictures \
>                 related data and properties,
> * saving of picture data via KoStore, 
> * sharing of picture storage information with in-line picture handler,   
> * processing of wrapping related information (support added to libmso),     
> 
> TODO: 
> 1. I have spent a lot of time with support for user edited wrapping, I'm still \
> wondering in witch units are the point coordinates stored.  There's a \
> draw:contour-polygon element inside of a draw:frame element, someone with good \
> knowledge of their coordinate systems relation could review this.  
> 2. The in-line object handler is going to be rewritten with usage of libmso.  \
> Support for required properties has been already added into libmso.  We can then \
> merge picture handler and drawing handler.             
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kword/msword-odf/document.h 1121027 
> trunk/koffice/filters/kword/msword-odf/document.cpp 1121027 
> trunk/koffice/filters/kword/msword-odf/graphicshandler.h 1121027 
> trunk/koffice/filters/kword/msword-odf/graphicshandler.cpp 1121027 
> trunk/koffice/filters/kword/msword-odf/mswordodfimport.cpp 1121027 
> trunk/koffice/filters/kword/msword-odf/wv2/src/graphics.h 1121027 
> trunk/koffice/filters/kword/msword-odf/wv2/src/graphics.cpp 1121027 
> trunk/koffice/filters/kword/msword-odf/wv2/src/handlers.h 1121027 
> trunk/koffice/filters/kword/msword-odf/wv2/src/handlers.cpp 1121027 
> trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.cpp 1121027 
> 
> Diff: http://reviewboard.kde.org/r/3949/diff
> 
> 
> Testing
> -------
> 
> Tested with oowriter, there's quite good support for wrapping effects, except for \
> user edited wrap point.     
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]