[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    RE: Review Request: bug fix "Text displayed at wrong place in this
From:       Hanzes Matus <matus.hanzes () ixonos ! com>
Date:       2010-05-11 15:14:39
Message-ID: C495228385CC1D409A54846080C9CBA568B3CD599E () jklmail01 ! ixonos ! local
[Download RAW message or body]

> From: Thomas Zander [mailto:zander@kde.org]
> Sent: 11. maj 2010 16:43
 
> > With the old approach there are 50 vertical enums needed and 91
> horizontal
> > enums.
> 
> Thats a rather staggering amount. Could you give some idea where this
> comes from? A couple of examples.

there are 7 horizontal-pos values, 13 horizontal-rel values, 7*13 = 91.

there are 5 vertical-pos values, 10 vertical-rel values, 5*10 = 50.
 
> > My proposal to move the layout recalculation code from
> KoAnchorStrategy to
> > KWTextDocumentLayout, is because I think there is no enough
> information in
> > KoAnchorStrategy to avoid unnecessary layout recalculations.  For
> example
> > when the anchored shape is in background there is no need for layout
> > recalculation.
> 
> While layout speed is important (though not nearly as important as
> painting speed) the maintainability of the code is much more important
> still. Did you write a lot of unit tests for this new design?

No.
I am waiting for approval that this new design is ok.
I will do them after the design approval.


_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]