[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Text displayed at wrong place in this
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-05-07 15:20:10
Message-ID: 20100507152010.32434.65887 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/
-----------------------------------------------------------

(Updated 2010-05-07 15:20:10.159565)


Review request for KOffice.


Changes
-------

More final patch
I have rewritten the KoTextAnchor and KwAnchorStrategy to support odf anchoring. 
I have modified KwFrameLayout to have the main text placed on page on same place as \
oowriter and msword have.

There are any issues to solve:

Releayout 
Previous KwAnchorStrategy moved the cursor position, but I think that \
KwAnchorStrategy is not the right place to do it. I think the right place to do it is \
KwTextDocumentLayout because there is more information available. (wrapping, \
outlines)

Lines
It seems that kword needs more space than oowriter or msword to show the same text. \
That is problem when shapes are anchored to lines or paragraphs.

Any comments and advices are welcome especially with the line problem.


Summary
-------

To place draw objects properly in kword document I needed to add more support for \
anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
 I tried to make anchoring backward compatible.

Comments are welcome.


Diffs (updated)
-----

  trunk/koffice/kword/part/KWPageStyle.h 1123976 
  trunk/koffice/kword/part/KWPageStyle.cpp 1123976 
  trunk/koffice/kword/part/KWPageStyle_p.h 1123976 
  trunk/koffice/kword/part/KWPageTextInfo.h 1123976 
  trunk/koffice/kword/part/KWPageTextInfo.cpp 1123976 
  trunk/koffice/kword/part/frames/KWAnchorStrategy.h 1123976 
  trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1123976 
  trunk/koffice/kword/part/frames/KWFrameLayout.cpp 1123976 
  trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1123976 
  trunk/koffice/libs/kotext/KoTextAnchor.h 1123976 
  trunk/koffice/libs/kotext/KoTextAnchor.cpp 1123976 
  trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1123976 

Diff: http://reviewboard.kde.org/r/3699/diff


Testing
-------


Thanks,

Matus

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]