[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Deleting the content of cells using "del" key in
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-05-03 11:54:13
Message-ID: 20100503115413.5071.34351 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3870/#review5369
-----------------------------------------------------------



trunk/koffice/kspread/part/View.cpp
<http://reviewboard.kde.org/r/3870/#comment5082>

    Fixing one bug at the expense of reintroducing another bug doesn't seem like a \
very good way (see http://bugs.kde.org/show_bug.cgi?id=173622 for the bug that would \
be reintroduced by this patch), so preferably you would try to find another way to \
get this to work.


- Marijn


On 2010-05-02 20:43:09, Pramod S G wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3870/
> -----------------------------------------------------------
> 
> (Updated 2010-05-02 20:43:09)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Bug 217542 -  it is not possible to delete a cell entry using the "del" key in \
> kspread 
> In KSpread,it was not possible to delete the content of a selected cell using the \
> "del" key, to which most people are accustomed. This also applies to selecting \
> multiple cells and deleting its content using the "del" key. I've added this \
> functionality and submitted for review. 
> 
> This addresses bug 217542.
> https://bugs.kde.org/show_bug.cgi?id=217542
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kspread/part/View.cpp 1121189 
> trunk/koffice/kspread/ui/CellToolBase.cpp 1121189 
> 
> Diff: http://reviewboard.kde.org/r/3870/diff
> 
> 
> Testing
> -------
> 
> I've tested this functionality successfully both for a single cell and multiple \
> cells. 
> 
> Thanks,
> 
> Pramod
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]