[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Enabling toggle grid functionality in the view
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-05-03 11:23:17
Message-ID: 20100503112317.4107.44293 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3856/#review5367
-----------------------------------------------------------


In addition to what already has been said, both OOo calc and Excel call those lines \
just "Grid lines"  or "Gridlines", so I would prefer to use that name in kspread as \
well, page grids just sounds strange.

- Marijn


On 2010-05-01 05:07:10, Srihari Prasad GV wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3856/
> -----------------------------------------------------------
> 
> (Updated 2010-05-01 05:07:10)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Bug 141406 -  JJ: enable toggling grid lines visibility
> I have added an option in the view menu and written toggle grid function which will \
> call setShowGrid().The page was not rendering correctly so I have called the \
> repaint function at the end.   
> 
> This addresses bug 141406.
> https://bugs.kde.org/show_bug.cgi?id=141406
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kspread/kspread.rc 1121182 
> trunk/koffice/kspread/kspread_readonly.rc 1121182 
> trunk/koffice/kspread/part/View.h 1121182 
> trunk/koffice/kspread/part/View.cpp 1121182 
> trunk/koffice/plugins/textshape/Layout.h 1121182 
> trunk/koffice/plugins/textshape/Layout.cpp 1121182 
> trunk/koffice/tools/f-office/AboutDialog.h 1121182 
> 
> Diff: http://reviewboard.kde.org/r/3856/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srihari
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]