[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add read-write / read-only switch to flake
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-04-30 15:14:47
Message-ID: 20100430151447.21313.87158 () localhost
[Download RAW message or body]



> On 2010-04-26 05:37:40, Boudewijn Rempt wrote:
> > There are a few coding style issues my main issue is more general: I think we \
> > originally intended that in a read-only part the tool shouldn't even be created, \
> > so the whole issue doesn't arise. This adds complexity to flake and needs work on \
> > all tools that add actions and it will very likely never be implemented \
> > comlpletely.
> 
> Thomas Zander wrote:
> > I think we originally intended that in a read-only part the tool shouldn't even \
> > be created
> Any reference to this? The todo to make this change has been there for over a year \
> at the request of Maemo. I discussed this with various team members back then, so \
> I'm surprised you heard something different that never reached my ear. 
> Anyway, I disagree that not using tools at all in that situation is a good \
> solution. It would disallow people selecting text, for one thing. I think being \
> able to copy (paste) from a read only document is still useful.  Next to that Maemo \
> uses the pan / zoom tools in the read-only viewer so what you suggest would make \
> that stop working too. 
> Boudewijn Rempt wrote:
> No, it's what I remember from our earliest discussions: since tools manipulate the \
> content, they should be disabled in a read-only environment. However, you are right \
> since we now also have tools that just manipulate the view that doesn't work well. 
> Instead of adding an api that causes work for application developers to support and \
> that seems to me fragile, I'd much prefer to have separate tools for the read-only \
> case. Some tools like zoom or pan could support both modes, for the text shape a \
> separate read-only and read/write tool would be better, in my opinion, sharing code \
> where possible, but not having lots of internal switches. 
> 

Ok, you disagree on the approach I took based on its fragile. So I made it not \
fragile in the update. Did you notice stuff is essentially disabled now unless the \
dev does something different? Sounds like an easier way to get viewer capability than \
creating a new texttool etc. :)

I don't really understand what it is you are saying. How do you think this issue can \
be fixed?


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3799/#review5231
-----------------------------------------------------------


On 2010-04-30 13:45:15, Thomas Zander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3799/
> -----------------------------------------------------------
> 
> (Updated 2010-04-30 13:45:15)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KOffice applications currently allow read and write editing even when being \
> embedded as a read-only kpart. So users can change text in an odt attachment for \
> email, but never get asked to save it. This patch extends the existing KParts \
> concept of read-only documents to Flake and specifically to KoToolBase and the \
> KoCanvasBase. 
> The patch allows tools to mark a KAction as one able to cause document changes as \
> well as provide a boolean getter so a tool can avoid mouse/keyboard/etc input from \
> modifying the document. The patch allows any canvas to be marked as read-only by \
> the application, which will cause the tool to be turned into a read-only one tool.  \
> (Remember we have a tool instance per canvas). 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWView.cpp 1120770 
> trunk/koffice/libs/flake/KoCanvasBase.h 1120770 
> trunk/koffice/libs/flake/KoCanvasBase.cpp 1120770 
> trunk/koffice/libs/flake/KoToolBase.h 1120770 
> trunk/koffice/libs/flake/KoToolBase.cpp 1120770 
> trunk/koffice/libs/flake/KoToolBase_p.h 1120770 
> trunk/koffice/libs/flake/KoToolManager.h 1120770 
> trunk/koffice/libs/flake/KoToolManager.cpp 1120770 
> trunk/koffice/plugins/textshape/TextTool.cpp 1120770 
> 
> Diff: http://reviewboard.kde.org/r/3799/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]