[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add read-write / read-only switch to flake
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-04-30 13:45:15
Message-ID: 20100430134515.18425.88096 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3799/
-----------------------------------------------------------

(Updated 2010-04-30 13:45:15.115720)


Review request for KOffice.


Changes
-------

    Reverse the tool read/write so all are 'dangerous' by default
    
    The idea that by default all actions are enabled and thus the user could
    modify (but not save) a doc is too dangerous, so lets reverse it so
    the developer has to make non-destructive available.


Summary
-------

KOffice applications currently allow read and write editing even when being embedded \
as a read-only kpart. So users can change text in an odt attachment for email, but \
never get asked to save it. This patch extends the existing KParts concept of \
read-only documents to Flake and specifically to KoToolBase and the KoCanvasBase.

The patch allows tools to mark a KAction as one able to cause document changes as \
well as provide a boolean getter so a tool can avoid mouse/keyboard/etc input from \
modifying the document. The patch allows any canvas to be marked as read-only by the \
application, which will cause the tool to be turned into a read-only one tool.  \
(Remember we have a tool instance per canvas).


Diffs (updated)
-----

  trunk/koffice/kword/part/KWView.cpp 1120770 
  trunk/koffice/libs/flake/KoCanvasBase.h 1120770 
  trunk/koffice/libs/flake/KoCanvasBase.cpp 1120770 
  trunk/koffice/libs/flake/KoToolBase.h 1120770 
  trunk/koffice/libs/flake/KoToolBase.cpp 1120770 
  trunk/koffice/libs/flake/KoToolBase_p.h 1120770 
  trunk/koffice/libs/flake/KoToolManager.h 1120770 
  trunk/koffice/libs/flake/KoToolManager.cpp 1120770 
  trunk/koffice/plugins/textshape/TextTool.cpp 1120770 

Diff: http://reviewboard.kde.org/r/3799/diff


Testing
-------


Thanks,

Thomas

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]