-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/#review5316
-----------------------------------------------------------


I'm fine with the initial approach too, I was waiting for a more finished patch as this one has lots of unimplemented cases left :)
I think we should get a version that loads the ODF totally into the anhcor enums and thus avoid having the verticalPos/verticalRel etc QStrings on the private object.

Notice also that; I'm getting warnings due to this change;

koffice/libs/kotext/KoTextAnchor.cpp: In member function 'QString KoTextAnchorPrivate::anchorPosition() const':
koffice/libs/kotext/KoTextAnchor.cpp:109: warning: enumeration value 'TopOfPage' not handled in switch
koffice/libs/kotext/KoTextAnchor.cpp:109: warning: enumeration value 'BottomOfPage' not handled in switch
koffice/libs/kotext/KoTextAnchor.cpp:119: warning: enumeration value 'LeftOfPage' not handled in switch
koffice/libs/kotext/KoTextAnchor.cpp: In member function 'virtual void KoTextAnchor::saveOdf(KoShapeSavingContext&)':
koffice/libs/kotext/KoTextAnchor.cpp:317: warning: enumeration value 'TopOfPage' not handled in switch 
koffice/libs/kotext/KoTextAnchor.cpp:317: warning: enumeration value 'BottomOfPage' not handled in switch 


trunk/koffice/kword/part/KWPageTextInfo.h
<http://reviewboard.kde.org/r/3699/#comment5003>

    Page is a value class, so to avoid crashes this should be returned by value, not by pointer.
    
    The method can be const too, as all getters tend to be const :)


- Thomas


On 2010-04-28 16:43:47, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3699/
> -----------------------------------------------------------
> 
> (Updated 2010-04-28 16:43:47)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> To place draw objects properly in kword document I needed to add more support for anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
> I tried to make anchoring backward compatible.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/kword/part/KWPageTextInfo.h 1120108 
>   trunk/koffice/kword/part/KWPageTextInfo.cpp 1120108 
>   trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1120108 
>   trunk/koffice/libs/kotext/KoTextAnchor.h 1120108 
>   trunk/koffice/libs/kotext/KoTextAnchor.cpp 1120108 
>   trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1120108 
> 
> Diff: http://reviewboard.kde.org/r/3699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel