[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [patch] compile fix for Layout.cpp
From:       Jaroslaw S <kexipl () gmail ! com>
Date:       2010-04-29 16:35:17
Message-ID: k2z56a746381004290935ta68e530drb8a7952a16ef2af8 () mail ! gmail ! com
[Download RAW message or body]

On 29 April 2010 18:15, Thomas Zander <zander@kde.org> wrote:
> On Thursday 29. April 2010 17.42.14 Jaroslaw Staniek wrote:
>> Hi,
>> For review - a fix for build (trunk) with Qt 4.5.2.
>
> For trunk? No, I don't think we should go that way. Thats just causing a lot
> of pain. Please allow trunk to depend on 4.6 at minimum.

The same pain coming from the non-ideal world that we have in Qt now [1].

4.6.x is the newest possible version now. We already had discussions
that supporting version-1 as bearable minimum makes sense, e.g. makes
it possible to create 3rdparty backports. Otherwise patches will be
floating here and there, and in Qt 4.7 there will be more cool
features that will make 4.6 "not the best enough".

As for the code that use weak pointers - I find it surprising that Qt
did not have the full API (missing methods) from the beginning (when
the class was introducted). So we can either use boost replacement or
the ifdefs. I have similar tolerant policy for other dependencies,
e.g. libmysql. Qt is just a tool after all, not a reason for existence
of KOffice.

[1] Q_CC_NOKIAX86 ifdefs...

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & KOffice (http://www.kexi-project.org, http://www.koffice.org)
 KDE Software Development Platform on MS Windows (http://windows.kde.org)
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]