[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Add read-write / read-only switch to flake
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-04-26 5:37:10
Message-ID: 20100426053710.8260.93535 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3799/#review5231
-----------------------------------------------------------


There are a few coding style issues my main issue is more general: I think we \
originally intended that in a read-only part the tool shouldn't even be created, so \
the whole issue doesn't arise. This adds complexity to flake and needs work on all \
tools that add actions and it will very likely never be implemented comlpletely.


trunk/koffice/libs/flake/KoToolBase.cpp
<http://reviewboard.kde.org/r/3799/#comment4727>

    Coding style: braces are not optional.



trunk/koffice/libs/flake/KoToolBase.cpp
<http://reviewboard.kde.org/r/3799/#comment4728>

    Coding style: braces are not optional.



trunk/koffice/libs/flake/KoToolBase.cpp
<http://reviewboard.kde.org/r/3799/#comment4729>

    Coding style: braces are not optional.



trunk/koffice/libs/flake/KoToolManager.cpp
<http://reviewboard.kde.org/r/3799/#comment4730>

    Coding style: braces are not optional.



trunk/koffice/libs/flake/KoToolManager.cpp
<http://reviewboard.kde.org/r/3799/#comment4731>

    Coding style: abbreviated variable name.



trunk/koffice/libs/flake/KoToolManager.cpp
<http://reviewboard.kde.org/r/3799/#comment4732>

    Coding style: braces are not optional.



trunk/koffice/plugins/textshape/TextTool.cpp
<http://reviewboard.kde.org/r/3799/#comment4734>

    Coding style: abbreviated variable name



trunk/koffice/plugins/textshape/TextTool.cpp
<http://reviewboard.kde.org/r/3799/#comment4733>

    abbreviated variable name


- Boudewijn


On 2010-04-24 08:49:04, Thomas Zander wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3799/
> -----------------------------------------------------------
> 
> (Updated 2010-04-24 08:49:04)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KOffice applications currently allow read and write editing even when being \
> embedded as a read-only kpart. So users can change text in an odt attachment for \
> email, but never get asked to save it. This patch extends the existing KParts \
> concept of read-only documents to Flake and specifically to KoToolBase and the \
> KoCanvasBase. 
> The patch allows tools to mark a KAction as one able to cause document changes as \
> well as provide a boolean getter so a tool can avoid mouse/keyboard/etc input from \
> modifying the document. The patch allows any canvas to be marked as read-only by \
> the application, which will cause the tool to be turned into a read-only one tool.  \
> (Remember we have a tool instance per canvas). 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWView.cpp 1118277 
> trunk/koffice/libs/flake/KoCanvasBase.h 1118277 
> trunk/koffice/libs/flake/KoCanvasBase.cpp 1118277 
> trunk/koffice/libs/flake/KoToolBase.h 1118277 
> trunk/koffice/libs/flake/KoToolBase.cpp 1118277 
> trunk/koffice/libs/flake/KoToolBase_p.h 1118277 
> trunk/koffice/libs/flake/KoToolManager.h 1118277 
> trunk/koffice/libs/flake/KoToolManager.cpp 1118277 
> trunk/koffice/plugins/textshape/TextTool.cpp 1118277 
> 
> Diff: http://reviewboard.kde.org/r/3799/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]