[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: load table:table as part of a draw:frame in the
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-04-25 9:44:50
Message-ID: 20100425094450.10149.43650 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3805/#review5215
-----------------------------------------------------------


Thanks for working on this :)
I'm just giving this a general overview, I don't know the odf loading all that well. \
The QPair looks very complicated to me so I gave it some thought how to make it \
simpler.  Hope it makes sense.


trunk/koffice/libs/flake/KoShapeFactoryBase.h
<http://reviewboard.kde.org/r/3805/#comment4708>

    Instead of a QList<QPair<QString, QStringList> >
    would it be possible to use a QHash<QString, QStringList>  ?



trunk/koffice/libs/flake/KoShapeFactoryBase.cpp
<http://reviewboard.kde.org/r/3805/#comment4709>

    Now we no longer return a odfNameSpace() as a QString I'd like to suggest that \
the namespace is kept as a const char *.  The advantage there is that we can use the \
pointers from KoXmlNS and thus only do pointer comparison for namespaces.  Which \
means that we avoid converting to utf16 (QString native) on call to \
setOdfElementNames and avoid a string compare.  That should make a significant impact \
in startup time too :)  
    This, together with the previous suggestion, would make the elements stored like;
    QHash<char*, QStringList>



trunk/koffice/plugins/textshape/TextShape.cpp
<http://reviewboard.kde.org/r/3805/#comment4710>

    I don't understand that '!' (not) there. That doesn't make sense to be there IMO.
    Can you add a comment perhaps?


- Thomas


On 2010-04-25 06:55:45, Thorsten Zachmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3805/
> -----------------------------------------------------------
> 
> (Updated 2010-04-25 06:55:45)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Make it possible to load a table:table inside a draw:frame. To make this possible \
> it is needed to extend KoShapeFactory and KoShapeRegistry that multiple namespaces \
> -> tag's can be supported by one shape. 
> 
> This addresses bug 231680.
> https://bugs.kde.org/show_bug.cgi?id=231680
> 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/flake/KoShapeFactoryBase.h 1118236 
> trunk/koffice/libs/flake/KoShapeFactoryBase.cpp 1118236 
> trunk/koffice/libs/flake/KoShapeRegistry.cpp 1118236 
> trunk/koffice/libs/flake/tests/TestKoShapeFactory.cpp 1118236 
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1118236 
> trunk/koffice/plugins/textshape/TextShape.h 1118236 
> trunk/koffice/plugins/textshape/TextShape.cpp 1118236 
> trunk/koffice/plugins/textshape/TextShapeFactory.cpp 1118236 
> 
> Diff: http://reviewboard.kde.org/r/3805/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thorsten
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]