[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: 'Combined characters' support for KWord
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2010-04-23 11:59:16
Message-ID: 20100423115916.4918.92218 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3701/#review5183
-----------------------------------------------------------

Ship it!


Looks fine.  You have to commit in the branch, though, because of the missing save \
feature.

- Inge


On 2010-04-23 09:38:13, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3701/
> -----------------------------------------------------------
> 
> (Updated 2010-04-23 09:38:13)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This code adds displaying of combined characters into KWord using KoFormulaShape by \
> generating appropriate MathML code. This is the 1st version, because currently the \
> KoFormulaShape ignores the width and height attributes and thus the displayed size \
> is always 50pt by 50pt (will have to check the KoFormulaShape deeper) and thus the \
> final size of the combined characters is not as small as a regular character (but \
> the patch as a whole is 95% complete). Please take a look and post comments if you \
> have some. 
> 
> Diffs
> -----
> 
> /trunk/koffice/kformula/flake/KoFormulaShapeFactory.cpp 1117436 
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1117436 
> /trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1117436 
> /trunk/koffice/libs/kotext/styles/KoCharacterStyle.cpp 1117436 
> 
> Diff: http://reviewboard.kde.org/r/3701/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]