[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix "Text displayed at wrong place in this
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-04-22 3:30:41
Message-ID: 20100422033041.20492.90464 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3699/#review5155
-----------------------------------------------------------


Once the patch is ready I can help with the saving part so that it can go into trunk


trunk/koffice/libs/flake/KoShape.h
<http://reviewboard.kde.org/r/3699/#comment4650>

    not needed if bool KoTextAnchor::loadOdfFromShape changed as proposed.



trunk/koffice/libs/flake/KoShape.cpp
<http://reviewboard.kde.org/r/3699/#comment4649>

    The reading of these style attributes should not be done in KoShape, as then it \
is done for every shape when loading but is not needed in the most time of cases.   \
Instead please extend   bool KoTextAnchor::loadOdfFromShape(const KoXmlElement& \
element)                                                                            \
to  bool KoTextAnchor::loadOdfFromShape(const KoXmlElement& element, \
KoShapeLoadingContext &context)                                                       \
  which allows you to read the styles only in the case where it is needed.
    
    You can have a look at KoShape::loadStyle to get an idea on how to do that.



trunk/koffice/libs/flake/KoShape.cpp
<http://reviewboard.kde.org/r/3699/#comment4651>

    not needed if bool KoTextAnchor::loadOdfFromShape changed as proposed.



trunk/koffice/libs/kotext/KoTextAnchor.cpp
<http://reviewboard.kde.org/r/3699/#comment4652>

    Needs some rework to use a passed context to read the styles.



trunk/koffice/libs/kotext/KoTextAnchor.cpp
<http://reviewboard.kde.org/r/3699/#comment4653>

    will you also add the other combinations?


- Thorsten


On 2010-04-21 12:38:12, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3699/
> -----------------------------------------------------------
> 
> (Updated 2010-04-21 12:38:12)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> To place draw objects properly in kword document I needed to add more support for \
> anchoring in kword.(style:vertical-pos,style:vertical-rel,style:horizontal-pos,style:vertical-rel)
>  I tried to make anchoring backward compatible.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWPageTextInfo.h 1116327 
> trunk/koffice/kword/part/KWPageTextInfo.cpp 1116327 
> trunk/koffice/kword/part/frames/KWAnchorStrategy.cpp 1116327 
> trunk/koffice/libs/flake/KoShape.h 1116327 
> trunk/koffice/libs/flake/KoShape.cpp 1116327 
> trunk/koffice/libs/kotext/KoTextAnchor.h 1116327 
> trunk/koffice/libs/kotext/KoTextAnchor.cpp 1116327 
> 
> Diff: http://reviewboard.kde.org/r/3699/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]