[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Quality control for 2.2 and unit tests
From:       Dmitry Kazakov <dimula73 () gmail ! com>
Date:       2010-04-21 15:15:37
Message-ID: y2oae32c1ef1004210815j8399306fm540c2c2f53720e5c () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Apr 21, 2010 at 6:06 PM, Cyrille Berger <cberger@cberger.net> wrote:

> On Wednesday 21 April 2010, Dmitry Kazakov wrote:
> > > * koffice/krita/image/tests/KisConvolutionPainterTest
> > > * koffice/krita/image/tests/KisAsyncMergerTest
> > > Those tests are bad tests and mostly need to regenerate an image and
> > > check that the generated image is still "correct".
> >
> > AsyncMerger fails because of the buggy convolution painter. Merger test
> > uses blur filter internally to check border-effect problems.
> It still fails for me with FFTW3 convolution painter, that should not have
> that problem, right ? (but then the resulting image is still different than
> with regular convolution)
>
FFTW3 version is buggy too. Do you remember my recent mail? [1]


[1] -
http://old.nabble.com/Spatial-convolution-worker-vs-beta-release-tt28122214.html#a28269196
-- 
Dmitry Kazakov

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Wed, Apr 21, 2010 at 6:06 PM, Cyrille Berger \
<span dir="ltr">&lt;<a \
href="mailto:cberger@cberger.net">cberger@cberger.net</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div><div></div><div \
class="h5">On Wednesday 21 April 2010, Dmitry Kazakov wrote:<br> &gt; &gt; * \
koffice/krita/image/tests/KisConvolutionPainterTest<br> &gt; &gt; * \
koffice/krita/image/tests/KisAsyncMergerTest<br> &gt; &gt; Those tests are bad tests \
and mostly need to regenerate an image and<br> &gt; &gt; check that the generated \
image is still &quot;correct&quot;.<br> &gt;<br>
&gt; AsyncMerger fails because of the buggy convolution painter. Merger test<br>
&gt; uses blur filter internally to check border-effect problems.<br>
</div></div>It still fails for me with FFTW3 convolution painter, that should not \
have<br> that problem, right ? (but then the resulting image is still different \
than<br> with regular convolution)<br>
</blockquote></div>FFTW3 version is buggy too. Do you remember my recent mail? [1]<br \
clear="all"><br><br>[1] - <a \
href="http://old.nabble.com/Spatial-convolution-worker-vs-beta-release-tt28122214.html \
#a28269196">http://old.nabble.com/Spatial-convolution-worker-vs-beta-release-tt28122214.html#a28269196</a><br>
                
-- <br>Dmitry Kazakov<br>



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]