[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Page numbers are not displayed properly in KWord
From:       "Pavol Korinek" <pavol.korinek () ixonos ! com>
Date:       2010-04-21 12:59:58
Message-ID: 20100421125958.31756.95046 () localhost
[Download RAW message or body]



> On 2010-04-21 09:13:13, Boudewijn Rempt wrote:
> > /trunk/koffice/libs/odf/KoGenStyle.h, line 384
> > <http://reviewboard.kde.org/r/3472/diff/2/?file=23617#file23617line384>
> > 
> > Is it really needed to remove "private:" here?

I thing that I have no other chance. I'll explain why: there is a \
applyParagraphProperties static method used to modify paragraph style. Then I need to \
check if allign was set. I need to call this "private" method. I was thinking about \
other possibilities: 1. change applyParagraphProperties to non static and set some \
class flag, but it can not be simply done because of other method call dependencies. \
2. use same test as is used inside of applyParagraphProperties, but that values are \
changed inside, so I can not use it than.


- Pavol


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3472/#review5130
-----------------------------------------------------------


On 2010-04-15 12:51:36, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3472/
> -----------------------------------------------------------
> 
> (Updated 2010-04-15 12:51:36)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch solves problems with page numbering in filter.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/filters/kword/msword-odf/paragraph.h 1114738 
> /trunk/koffice/filters/kword/msword-odf/paragraph.cpp 1114738 
> /trunk/koffice/filters/kword/msword-odf/texthandler.h 1114738 
> /trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1114738 
> /trunk/koffice/libs/odf/KoGenStyle.h 1114738 
> 
> Diff: http://reviewboard.kde.org/r/3472/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]