[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: msword-odf filter: horizontal alignment and
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-04-20 17:45:23
Message-ID: 20100420174523.2955.32214 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3677/#review5121
-----------------------------------------------------------

Ship it!


looks good
I'm fine with committing to trunk


trunk/koffice/filters/kword/msword-odf/tablehandler.cpp
<http://reviewboard.kde.org/r/3677/#comment4625>

    addPropertyPt is probably a better fit


- Casper


On 2010-04-20 15:16:54, Matus Uzak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3677/
> -----------------------------------------------------------
> 
> (Updated 2010-04-20 15:16:54)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> List of changes: 
> * If a table is located in a header or footer, write all of it's styles into \
>                 styles.xml (instead of content.xml).
> * Support for horizontal table alignment has been added into the parser and into \
>                 the table handler.
> * Support for the "indent from left" option has been added into the parser and into \
> the table handler (margin-left attribute is used). 
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kword/msword-odf/graphicshandler.cpp 1115392 
> trunk/koffice/filters/kword/msword-odf/tablehandler.h 1115392 
> trunk/koffice/filters/kword/msword-odf/tablehandler.cpp 1115392 
> trunk/koffice/filters/kword/msword-odf/texthandler.cpp 1115392 
> trunk/koffice/filters/kword/msword-odf/wv2/src/ms_odraw.h 1115392 
> trunk/koffice/filters/kword/msword-odf/wv2/src/parser9x.cpp 1115392 
> trunk/koffice/filters/kword/msword-odf/wv2/src/word97_generated.h 1115392 
> trunk/koffice/filters/kword/msword-odf/wv2/src/word97_generated.cpp 1115392 
> trunk/koffice/filters/kword/msword-odf/wv2/src/word97_helper.cpp 1115392 
> 
> Diff: http://reviewboard.kde.org/r/3677/diff
> 
> 
> Testing
> -------
> 
> Testing of the msword-odf filter output done with oowriter-3.1.1, kword is actually \
> not displaying tables properly. 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]