[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KRITA: fix for Bug 185767 - Tool buttons don't get
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2010-04-11 5:41:11
Message-ID: 20100411054111.8349.42753 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3562/#review4963
-----------------------------------------------------------


Why did you use "krita/always" as activation id ? The "always" part means that the \
activation of the tool is unaffected by locking, which is very wrong for painting \
tools. Maybe just "krita" is enough ?

- Cyrille


On 2010-04-11 00:34:05, Adam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3562/
> -----------------------------------------------------------
> 
> (Updated 2010-04-11 00:34:05)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> this "fix" switches of the disabling of the tool buttons. this should be enough for \
> the 2.2 release. 
> in my opinion KoToolManager needs more features for fixing this correctly, which i \
> don't want to do during the code freeze. these features would include switching off \
> and on tool groups on demand and not only through selecting and deselecting objects \
> or layers. 
> 
> This addresses bug 185767.
> https://bugs.kde.org/show_bug.cgi?id=185767
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_brush.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_colorpicker.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_ellipse.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_fill.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_gradient.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_line.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_measure.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_move.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_path.h 1113396 
> /trunk/koffice/krita/plugins/tools/defaulttools/kis_tool_rectangle.h 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_brush.h 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_contiguous.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_elliptical.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_magnetic.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_outline.h 1113396 \
>                 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_path.h 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_polygonal.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_rectangular.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/selectiontools/kis_tool_select_similar.h 1113396 \
>                 
> /trunk/koffice/krita/plugins/tools/tool_crop/kis_tool_crop.h 1113396 
> /trunk/koffice/krita/plugins/tools/tool_dyna/kis_tool_dyna.h 1113396 
> /trunk/koffice/krita/plugins/tools/tool_grid/kis_tool_grid.h 1113396 
> /trunk/koffice/krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/tool_perspectivetransform/kis_tool_perspectivetransform.h \
>                 1113396 
> /trunk/koffice/krita/plugins/tools/tool_polygon/kis_tool_polygon.h 1113396 
> /trunk/koffice/krita/plugins/tools/tool_polyline/kis_tool_polyline.h 1113396 
> /trunk/koffice/krita/plugins/tools/tool_star/kis_tool_star.h 1113396 
> /trunk/koffice/krita/plugins/tools/tool_transform/kis_tool_transform.h 1113396 
> /trunk/koffice/krita/ui/tool/kis_tool.h 1113396 
> 
> Diff: http://reviewboard.kde.org/r/3562/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Adam
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]