[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix: "Picture inserted as background fill not
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-04-09 8:07:39
Message-ID: 20100409080739.2715.92322 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3443/#review4934
-----------------------------------------------------------


I haven't tested it yet -- but if you have tested it with one or more test documents, \
then I think you should commit. Codewise it looks ok.

- Boudewijn


On 2010-03-30 07:15:12, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3443/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 07:15:12)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This fix adds support for page background pictures in docx filter.
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/filters/kword/docx/DocxXmlDocumentReader.cpp 1108939 
> trunk/koffice/filters/libmsooxml/MsooXmlVmlReaderImpl.h 1108939 
> trunk/koffice/filters/libmsooxml/MsooXmlVmlReaderMethods.h 1108939 
> 
> Diff: http://reviewboard.kde.org/r/3443/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]