[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: bug fix: "Picture inserted as background fill not
From:       "Matus Hanzes" <matus.hanzes () ixonos ! com>
Date:       2010-04-01 14:39:15
Message-ID: 20100401143915.16475.58147 () localhost
[Download RAW message or body]



> On 2010-04-01 12:48:16, Thomas Zander wrote:
> > trunk/koffice/kword/part/KWPageStyle.cpp, line 363
> > <http://reviewboard.kde.org/r/3444/diff/1/?file=22175#file22175line363>
> > 
> > Why did you add this check?  This makes the usecase (3 lines lower) of a \
> > transparent color not work anymore. 
> > Also, please don't use NULL, thats a C not a C++ keyword. In C++ we just use 0

If d->background != 0 the right place to support background color would be in \
KoPatternBackground, but KoPatternBackground is not supporting background color.


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3444/#review4837
-----------------------------------------------------------


On 2010-03-30 07:18:37, Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3444/
> -----------------------------------------------------------
> 
> (Updated 2010-03-30 07:18:37)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This fix adds support for page background pictures in kword
> 
> loadOdf function changed to loadOdfPageBackgroundImage. 
> 
> Comments are welcome.
> 
> 
> Diffs
> -----
> 
> trunk/koffice/kword/part/KWOdfLoader.cpp 1108939 
> trunk/koffice/kword/part/KWPageStyle.h 1108939 
> trunk/koffice/kword/part/KWPageStyle.cpp 1108939 
> trunk/koffice/libs/flake/KoPatternBackground.h 1108939 
> trunk/koffice/libs/flake/KoPatternBackground.cpp 1108939 
> 
> Diff: http://reviewboard.kde.org/r/3444/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]