From koffice-devel Wed Mar 31 16:38:42 2010 From: "Carlos Licea" Date: Wed, 31 Mar 2010 16:38:42 +0000 To: koffice-devel Subject: Re: Review Request: kword is not showing the colored arrows Message-Id: <20100331163842.14645.26746 () localhost> X-MARC-Message: https://marc.info/?l=koffice-devel&m=127005356606909 > On 2010-03-31 10:34:51, Thorsten Zachmann wrote: > > What was the reason to discard this? I think it should go in to fix the problem when loading odt files generated by OO > > Pavol Korinek wrote: > The reason is that input file is wrong. There is not only this one attribute missing, but more attributes, which lead to more and more errors, problems and workarrounds. I thing Thomas has same oppinion. If I can have an opinion, I don't think that the workaround is wrong, it's after all a workaround. I don't see that much of a performance hit, only if there's no fill attribute the workaround may apply. Also, please have a look at KoOdfWorkaround, most (if not all) of the workarounds are there because of faulty OOo implementations, this is not different (fixEnhancedPath is pretty close to it, it adds an attribute that wasn't set; fixMissingFillColor is almost the same thing as this patch, only that is applied to charts; fixMissingStrokeColor, is also the same that this patch). The concerns arose are, in my opinion, not valid. We already fix wrong assumptions and bad documents, why is this different? - Carlos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3290/#review4810 ----------------------------------------------------------- On 2010-03-15 09:08:19, Pavol Korinek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3290/ > ----------------------------------------------------------- > > (Updated 2010-03-15 09:08:19) > > > Review request for KOffice. > > > Summary > ------- > > This patch solves problem when loading OpenOffice odt documents which doesn't have fill attribute used in custom-shape. > > > Diffs > ----- > > trunk/koffice/libs/flake/KoOdfWorkaround.h 1101092 > trunk/koffice/libs/flake/KoOdfWorkaround.cpp 1101092 > trunk/koffice/libs/flake/KoShape.cpp 1101092 > > Diff: http://reviewboard.kde.org/r/3290/diff > > > Testing > ------- > > Patch was tested. > > > Thanks, > > Pavol > > _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel