From koffice-devel  Mon Mar 29 16:36:41 2010
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: Mon, 29 Mar 2010 16:36:41 +0000
To: koffice-devel
Subject: Re: Review Request: Don't publish wv2 from koffice.
Message-Id: <20100329163641.14420.39716 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126988065310564


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3437/#review4738
-----------------------------------------------------------


Looks fine, apart from the removal of koreport. It's Cyrille's call, though.


trunk/koffice/libs/CMakeLists.txt
<http://reviewboard.kde.org/r/3437/#comment4254>

    I think this is unintentional, isn't it?


- Boudewijn


On 2010-03-29 16:28:21, Shaheed Haque wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3437/
> -----------------------------------------------------------
> 
> (Updated 2010-03-29 16:28:21)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Rename wv2 to kowv2, and stop publishing header files etc. that give the impression this is a public API (and one that collides with the "old" wv2 to boot).
> 
> Requesting approval during freeze to avoid this going out into the wild!
> 
> 
> Diffs
> -----
> 
>   trunk/koffice/filters/kword/msword-odf/CMakeLists.txt 1108583 
>   trunk/koffice/filters/kword/msword-odf/wv2/CMakeLists.txt 1108583 
>   trunk/koffice/filters/kword/msword-odf/wv2/src/CMakeLists.txt 1108583 
>   trunk/koffice/libs/CMakeLists.txt 1108583 
> 
> Diff: http://reviewboard.kde.org/r/3437/diff
> 
> 
> Testing
> -------
> 
> 1. Ran regression tests from kofficetests/interoperability/kword.
> 2. Checked library dependencies:
> 
> > ldd/usr/local/lib/kde4/libmswordodf_import.so|grep wv
>         libkowv2.so.4 => /usr/local/lib/libkowv2.so.4 (0x00007f87ae3f6000)
> 
> 
> Thanks,
> 
> Shaheed
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel