From koffice-devel  Mon Mar 29 14:06:08 2010
From: "Thomas Zander" <zander () kde ! org>
Date: Mon, 29 Mar 2010 14:06:08 +0000
To: koffice-devel
Subject: Re: Review Request: Exact row height in KWord tables added
Message-Id: <20100329140608.10503.44381 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126987159326814


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/#review4735
-----------------------------------------------------------



/trunk/koffice/plugins/textshape/TableLayout.cpp
<http://reviewboard.kde.org/r/3319/#comment4253>

    If you have 2 cells in the same row then the height of the first cell is completely ignored as you overwrite the rowHeight when you get to the second cell irregardless of what it was set to at that point.


- Thomas


On 2010-03-22 13:42:42, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated 2010-03-22 13:42:42)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This adds the exact row height to the tables of KWord (exact row height is an attribute from MS Word document as a complement to the minimum row height). The text which does not fit in a cell in a row of small height is not displayed this way (does not go outside the cell). The other option would be to clip the text, but as that didn't work for the QTextLayout::draw(...) this approach of not showing was chosen. Clipping would be nicer, not showing is faster.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1106291 
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1106291 
>   /trunk/koffice/plugins/textshape/Layout.cpp 1106291 
>   /trunk/koffice/plugins/textshape/TableLayout.cpp 1106291 
> 
> Diff: http://reviewboard.kde.org/r/3319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel