[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Exact row height in KWord tables added
From:       "Miroslav Nohaj" <miroslav.nohaj () ixonos ! com>
Date:       2010-03-29 13:26:38
Message-ID: 20100329132638.9707.59114 () localhost
[Download RAW message or body]



> On 2010-03-28 18:36:01, Thomas Zander wrote:
> > /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h, line 89
> > <http://reviewboard.kde.org/r/3319/diff/4/?file=21375#file21375line89>
> > 
> > The API docs should be a bit more verbose than this, please explain what exactly \
> > this feature does

OK, will do that... In most cases I'm just trying to imitate the style and amount of \
comments or the style of programming from the sources, but it seems as not the best \
idea :)


> On 2010-03-28 18:36:01, Thomas Zander wrote:
> > /trunk/koffice/plugins/textshape/Layout.cpp, line 1009
> > <http://reviewboard.kde.org/r/3319/diff/4/?file=21377#file21377line1009>
> > 
> > Maybe your comment can describe why you are doing it instead of just saying what \
> > the code also says. 
> > Specifically, why are you using a different table than the table that is being \
> > processed in this method?

I'm doing that for the reason I need to access the whole (parent) table for the using \
of method cellAt(...). If there's another/better way of doing that, I won't mind to \
do that.


> On 2010-03-28 18:36:01, Thomas Zander wrote:
> > /trunk/koffice/plugins/textshape/TableLayout.cpp, line 295
> > <http://reviewboard.kde.org/r/3319/diff/4/?file=21378#file21378line295>
> > 
> > This logic looks wrong; it should reuse the rowHeight on the right side of the \
> > equal sign somehow. 
> > This will fail for cells with different heights when there is no row height set.

Could you, please, give an example of values of rowHeight, minimumRowHeight, \
cellHeight for which it would fail? I can't imagine them and if there's a flaw in \
this, then that would be a good test case for the issue.


- Miroslav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/#review4721
-----------------------------------------------------------


On 2010-03-22 13:42:42, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated 2010-03-22 13:42:42)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This adds the exact row height to the tables of KWord (exact row height is an \
> attribute from MS Word document as a complement to the minimum row height). The \
> text which does not fit in a cell in a row of small height is not displayed this \
> way (does not go outside the cell). The other option would be to clip the text, but \
> as that didn't work for the QTextLayout::draw(...) this approach of not showing was \
> chosen. Clipping would be nicer, not showing is faster. 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1106291 
> /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1106291 
> /trunk/koffice/plugins/textshape/Layout.cpp 1106291 
> /trunk/koffice/plugins/textshape/TableLayout.cpp 1106291 
> 
> Diff: http://reviewboard.kde.org/r/3319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]