-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/#review4721
-----------------------------------------------------------


I did find some issues and have a question or two.  Could you please take a look and update the patch? Thanks.


/trunk/koffice/libs/kotext/styles/KoTableRowStyle.h
<http://reviewboard.kde.org/r/3319/#comment4218>

    The API docs should be a bit more verbose than this, please explain what exactly this feature does



/trunk/koffice/libs/kotext/styles/KoTableRowStyle.h
<http://reviewboard.kde.org/r/3319/#comment4217>

    using const here is not right. Please remove.



/trunk/koffice/plugins/textshape/Layout.cpp
<http://reviewboard.kde.org/r/3319/#comment4219>

    Maybe your comment can describe why you are doing it instead of just saying what the code also says.
    
    Specifically, why are you using a different table than the table that is being processed in this method?



/trunk/koffice/plugins/textshape/TableLayout.cpp
<http://reviewboard.kde.org/r/3319/#comment4220>

    This logic looks wrong; it should reuse the rowHeight on the right side of the equal sign somehow.
    
    This will fail for cells with different heights when there is no row height set.


- Thomas


On 2010-03-22 13:42:42, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated 2010-03-22 13:42:42)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This adds the exact row height to the tables of KWord (exact row height is an attribute from MS Word document as a complement to the minimum row height). The text which does not fit in a cell in a row of small height is not displayed this way (does not go outside the cell). The other option would be to clip the text, but as that didn't work for the QTextLayout::draw(...) this approach of not showing was chosen. Clipping would be nicer, not showing is faster.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1106291 
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1106291 
>   /trunk/koffice/plugins/textshape/Layout.cpp 1106291 
>   /trunk/koffice/plugins/textshape/TableLayout.cpp 1106291 
> 
> Diff: http://reviewboard.kde.org/r/3319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel