[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Page border style not retained in Kword
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-03-24 11:36:39
Message-ID: 20100324113639.10622.99363 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3369/#review4663
-----------------------------------------------------------


With my comments there is nothing left of the patch, and it actually doesn't work any \
diffenrt from current behaviour


/trunk/koffice/filters/kword/msword-odf/conversion.cpp
<http://reviewboard.kde.org/r/3369/#comment4174>

    this line doesn't do anything. please remove



/trunk/koffice/filters/kword/msword-odf/conversion.cpp
<http://reviewboard.kde.org/r/3369/#comment4175>

    invalid odf
    
    you need to figure out a way to add an extra attribute with a koffice namespace, \
without messing up the current style attribute. During load you can then use this \
extra attribute to set a more accurate pattern than what odf alone can specify.



/trunk/koffice/filters/kword/msword-odf/conversion.cpp
<http://reviewboard.kde.org/r/3369/#comment4176>

    same as above



/trunk/koffice/kword/part/KWCanvas.cpp
<http://reviewboard.kde.org/r/3369/#comment4177>

    wrong usage. Don't use KoUnit - it doesn't handle pixels



/trunk/koffice/kword/part/KWCanvas.cpp
<http://reviewboard.kde.org/r/3369/#comment4178>

    dont use KoUnit
    



/trunk/koffice/kword/part/KWCanvas.cpp
<http://reviewboard.kde.org/r/3369/#comment4179>

    don't use kounit



/trunk/koffice/kword/part/KWCanvas.cpp
<http://reviewboard.kde.org/r/3369/#comment4180>

    don't use kounit


- Casper


On 2010-03-24 11:24:43, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3369/
> -----------------------------------------------------------
> 
> (Updated 2010-03-24 11:24:43)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch fixes painting borders of dot-dash and dot-dot styles. It also fixes \
> problem of painting borders with tiny width via antialliasing. 
> 
> Diffs
> -----
> 
> /trunk/koffice/filters/kword/msword-odf/conversion.cpp 1104986 
> /trunk/koffice/kword/part/KWCanvas.cpp 1104986 
> 
> Diff: http://reviewboard.kde.org/r/3369/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pavol
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]