[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Exact row height in KWord tables added
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2010-03-24 10:34:41
Message-ID: 201003241134.41355.cbo () boemann ! dk
[Download RAW message or body]

First of, it's not KWord but libs, and second as it's a feature its meant to 
go into the branch where freeze does not apply.



On Wednesday 24 March 2010 11:30:58 you wrote:
> Please don't Ok patches for KWord.
> 
> On Wednesday 24. March 2010 10.47.48 Casper Boemann wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3319/#review4658
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > besides thinking fixed would be a better name than exact: please commit
> >
> > - Casper
> >
> > On 2010-03-22 13:42:42, Miroslav Nohaj wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://reviewboard.kde.org/r/3319/
> > > -----------------------------------------------------------
> > >
> > > (Updated 2010-03-22 13:42:42)
> > >
> > >
> > > Review request for KOffice.
> > >
> > >
> > > Summary
> > > -------
> > >
> > > This adds the exact row height to the tables of KWord (exact row height
> > > is an attribute from MS Word document as a complement to the minimum
> > > row height). The text which does not fit in a cell in a row of small
> > > height is not displayed this way (does not go outside the cell). The
> > > other option would be to clip the text, but as that didn't work for the
> > > QTextLayout::draw(...) this approach of not showing was chosen.
> > > Clipping would be nicer, not showing is faster.
> > >
> > >
> > > Diffs
> > > -----
> > >
> > >   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1106291
> > >   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1106291
> > >   /trunk/koffice/plugins/textshape/Layout.cpp 1106291
> > >   /trunk/koffice/plugins/textshape/TableLayout.cpp 1106291
> > >
> > > Diff: http://reviewboard.kde.org/r/3319/diff
> > >
> > >
> > > Testing
> > > -------
> > >
> > >
> > > Thanks,
> > >
> > > Miroslav
> >
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/koffice-devel
> 
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]