[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Exact row height in KWord tables added
From:       Thomas Zander <zander () kde ! org>
Date:       2010-03-24 9:46:17
Message-ID: 201003241046.17988.zander () kde ! org
[Download RAW message or body]

KOffice is in deep-freeze so I'd like to run the patch myself before it gets 
committed.  I didn't have time for that yet.
Can the actual commit wait a little longer? I'll get to it as soon as I can.

On Wednesday 24. March 2010 10.29.04 Nohaj Miroslav wrote:
>   Hello,
> 
> I didn't get any response on the last change... Is it OK now to commit?
> 
> Best regards,
>   Miroslav
> 
> 
> 
> -----Original Message-----
> From: Miroslav Nohaj [mailto:miroslav.nohaj@ixonos.com]
> Sent: 22. marca 2010 14:43
> To: Thomas Zander; Nohaj Miroslav; Elvis Stansvik; Casper Boemann; KOffice
> Subject: Re: Review Request: Exact row height in KWord tables added
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated 2010-03-22 13:42:42.445719)
> 
> 
> Review request for KOffice.
> 
> 
> Changes
> -------
> 
> - replaced not drawing of block with the clipping when drawing.
> 
> 
> Summary
> -------
> 
> This adds the exact row height to the tables of KWord (exact row height is
> an attribute from MS Word document as a complement to the minimum row
> height). The text which does not fit in a cell in a row of small height is
> not displayed this way (does not go outside the cell). The other option
> would be to clip the text, but as that didn't work for the
> QTextLayout::draw(...) this approach of not showing was chosen. Clipping
> would be nicer, not showing is faster.
> 
> 
> Diffs (updated)
> -----
> 
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1106291
>   /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1106291
>   /trunk/koffice/plugins/textshape/Layout.cpp 1106291
>   /trunk/koffice/plugins/textshape/TableLayout.cpp 1106291
> 
> Diff: http://reviewboard.kde.org/r/3319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]