[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Exact row height in KWord tables added
From: "Miroslav Nohaj" <miroslav.nohaj () ixonos ! com>
Date: 2010-03-22 10:17:41
Message-ID: 20100322101741.19622.4688 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/
-----------------------------------------------------------
(Updated 2010-03-22 10:17:41.480573)
Review request for KOffice.
Changes
-------
- coding style fixed
- API doc added
- exactRowHeight renamed to rowHeight (although in the TableLayout.cpp the name \
stayed for local variable, because there is a different rowHeight \
already)
- used rowStyle->hasProperty(KoTableRowStyle::RowHeight) instead of (exactRowHeight > \
0.0)
Summary
-------
This adds the exact row height to the tables of KWord (exact row height is an \
attribute from MS Word document as a complement to the minimum row height). The text \
which does not fit in a cell in a row of small height is not displayed this way (does \
not go outside the cell). The other option would be to clip the text, but as that \
didn't work for the QTextLayout::draw(...) this approach of not showing was chosen. \
Clipping would be nicer, not showing is faster.
Diffs (updated)
-----
/trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1105136
/trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1105136
/trunk/koffice/plugins/textshape/Layout.cpp 1105136
/trunk/koffice/plugins/textshape/TableLayout.cpp 1105136
Diff: http://reviewboard.kde.org/r/3319/diff
Testing
-------
Thanks,
Miroslav
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic