[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Exact row height in KWord tables added
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2010-03-21 13:59:34
Message-ID: 20100321135934.3353.38583 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/#review4589
-----------------------------------------------------------


two small things. and a unit test for the feature would of course be nice.


/trunk/koffice/libs/kotext/styles/KoTableRowStyle.h
<http://reviewboard.kde.org/r/3319/#comment4082>

    in general i think these properties are named to match the element name, so maybe name it \
just RowHeight? though i'm kind of fine with ExactRowHeight too as it's more explicit about its \
function.



/trunk/koffice/plugins/textshape/Layout.cpp
<http://reviewboard.kde.org/r/3319/#comment4083>

    trailing whitespace.


- Elvis


On 2010-03-19 09:35:12, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated 2010-03-19 09:35:12)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This adds the exact row height to the tables of KWord (exact row height is an attribute from \
> MS Word document as a complement to the minimum row height). The text which does not fit in a \
> cell in a row of small height is not displayed this way (does not go outside the cell). The \
> other option would be to clip the text, but as that didn't work for the \
> QTextLayout::draw(...) this approach of not showing was chosen. Clipping would be nicer, not \
> showing is faster. 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1104658 
> /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1104658 
> /trunk/koffice/plugins/textshape/Layout.cpp 1104658 
> /trunk/koffice/plugins/textshape/TableLayout.cpp 1104658 
> 
> Diff: http://reviewboard.kde.org/r/3319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]