[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Don't expand filename in KoStore::hasFile()
From:       "Boudewijn Rempt" <boud () valdyas ! org>
Date:       2010-03-20 14:04:44
Message-ID: 20100320140444.10180.25388 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3316/#review4583
-----------------------------------------------------------

Ship it!


Please commit.

- Boudewijn


On 2010-03-18 13:32:09, langkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3316/
> -----------------------------------------------------------
> 
> (Updated 2010-03-18 13:32:09)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> With the patch the fileName isn't expanded in hasFile. In toExternalNaming that is \
> already done and when the currentPath isn't empty this will generate an invalid \
> path. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/odf/KoStore.cpp 1104501 
> trunk/koffice/libs/odf/tests/TestStorage.cpp 1104501 
> 
> Diff: http://reviewboard.kde.org/r/3316/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> langkamp
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]