[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Exact row height in KWord tables added
From:       "Casper Boemann" <cbr () boemann ! dk>
Date:       2010-03-19 10:33:59
Message-ID: 20100319103359.9125.51704 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3319/#review4567
-----------------------------------------------------------


in general this does the best of the two approaches thomas and i suggested. It \
doesn't draw without need, and it leaves the layout intact.

As such I like it. The actual code looks a little too verbose for my taste though - \
but I can't really quickly suggest a more efficient way of writing it, so i'm fine \
with the patch.

Thomas, comments?


/trunk/koffice/plugins/textshape/Layout.cpp
<http://reviewboard.kde.org/r/3319/#comment4041>

    style


- Casper


On 2010-03-19 09:35:12, Miroslav Nohaj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3319/
> -----------------------------------------------------------
> 
> (Updated 2010-03-19 09:35:12)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This adds the exact row height to the tables of KWord (exact row height is an \
> attribute from MS Word document as a complement to the minimum row height). The \
> text which does not fit in a cell in a row of small height is not displayed this \
> way (does not go outside the cell). The other option would be to clip the text, but \
> as that didn't work for the QTextLayout::draw(...) this approach of not showing was \
> chosen. Clipping would be nicer, not showing is faster. 
> 
> Diffs
> -----
> 
> /trunk/koffice/libs/kotext/styles/KoTableRowStyle.h 1104658 
> /trunk/koffice/libs/kotext/styles/KoTableRowStyle.cpp 1104658 
> /trunk/koffice/plugins/textshape/Layout.cpp 1104658 
> /trunk/koffice/plugins/textshape/TableLayout.cpp 1104658 
> 
> Diff: http://reviewboard.kde.org/r/3319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Miroslav
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]