[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Toolbox layout reviewal
From:       "Cyrille Berger" <cberger () cberger ! net>
Date:       2010-03-18 9:58:41
Message-ID: 20100318095841.17483.3577 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3243/
-----------------------------------------------------------

(Updated 2010-03-18 09:58:41.370681)


Review request for KOffice.


Changes
-------

Fix stray line being displayed after a section is hidden


Summary
-------

This patch is a revival of http://reviewboard.kde.org/r/782/ . The reason is that I \
(and from the review comments as well as list thread \
http://lists.kde.org/?t=124395874500007&r=1&w=2 some other agrees) the current layout \
code lead to messy. The main objection to the previous patch was that it took more \
space, this patch address the issue and put some groups on the same line when \
possible.

I have put screenshots of both layout with different size in \
http://cyrille.diwi.org/tmp/koffice/toolboxlayout/, the proposed patch leads to a \
less messy toolbox, as well as use less space.

Now to move forward, I had like all people to clearly state which layout they prefer. \
And also if anything works incorrectly with the new layout code, I am willing to work \
on it to fix any issues.

(I would also want to allow one column toolbox like we have one line horizontal \
toolbox, but I think it is Qt that prevent that to happen)


Diffs (updated)
-----

  /trunk/koffice/libs/main/KoMainWindow.cpp 1102761 
  /trunk/koffice/libs/main/KoToolBox.cpp 1102761 
  /trunk/koffice/libs/main/KoToolBox_p.h 1102761 
  /trunk/koffice/libs/widgets/KoDockWidgetTitleBar.h 1102761 
  /trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp 1102761 
  /trunk/koffice/libs/widgets/KoDockWidgetTitleBarButton.h 1102761 

Diff: http://reviewboard.kde.org/r/3243/diff


Testing
-------


Thanks,

Cyrille

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]