[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: kword is not showing the colored arrows
From:       "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date:       2010-03-17 6:27:35
Message-ID: 20100317062735.16753.33013 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3290/#review4527
-----------------------------------------------------------


The assumption that a missing style means no background was wrong. For no background \
the draw:fill="none" is used. Therefore I think it is not problematic that the code \
goes in. It will only be executed when the creator was OO which produced the faulty \
documents. Please update to follow the comments.


trunk/koffice/libs/flake/KoOdfWorkaround.cpp
<http://reviewboard.kde.org/r/3290/#comment3989>

    Please use the KoColorBackground::KoColorBackground(const QColor &color, \
Qt::BrushStyle style) to create a background with a defined color.  



trunk/koffice/libs/flake/KoShape.cpp
<http://reviewboard.kde.org/r/3290/#comment3990>

    Please move the workaround after the other fill checks into the else part. With \
that it is only executed if no other style is set which should limit performance \
penalties.                          
    Please move the check for fill.isEmpty to be done inside the KoOdfWorkaround, \
maybe by passing the fill to it.  This would make more clear what and why it is done. \
  Please add an else if for "none" to explicItely handle that no background is set in \
the style or add a comment about that.


- Thorsten


On 2010-03-15 09:08:19, Pavol Korinek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3290/
> -----------------------------------------------------------
> 
> (Updated 2010-03-15 09:08:19)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch solves problem when loading OpenOffice odt documents which doesn't have \
> fill attribute used in custom-shape. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/flake/KoOdfWorkaround.h 1101092 
> trunk/koffice/libs/flake/KoOdfWorkaround.cpp 1101092 
> trunk/koffice/libs/flake/KoShape.cpp 1101092 
> 
> Diff: http://reviewboard.kde.org/r/3290/diff
> 
> 
> Testing
> -------
> 
> Patch was tested.
> 
> 
> Thanks,
> 
> Pavol
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]