[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KoGenStyle(s) cleanup
From:       Thorsten Zachmann <t.zachmann () zagge ! de>
Date:       2010-03-08 14:21:10
Message-ID: 201003081521.10708.t.zachmann () zagge ! de
[Download RAW message or body]

On Monday 08 March 2010 14:12:36 Jaroslaw S wrote:
> On 8 March 2010 14:06, Jos van den Oever <Jos.van.den.Oever@kogmbh.com> 
wrote:
> > On Monday 08 March 2010 13:13:32 Jos van den Oever wrote:
> >> On Monday 08 March 2010 13:02:45 Thomas Zander wrote:
> >> >     enum values all currently are consistently starting with 'Style'
> >> > Or
> >> > 
> >> > StyleAuto, your change makes this inconsistent AFAICT. Starting and
> >> > ending with consistent wording is nowhere near as logical as only
> >> > starting with a consistent wording.
> >> 
> >> No, the changes makes them consistently end with Auto. It's debatable if
> >> AutoStyle* would be better than Style*Auto, but the current change
> >> *improves* consistency.
> > 
> > Just chatted with TZander. We both like the AutoStyle* naming. If
> > Jaroslaw agrees (and nobody else objects) that would be a solution.
> > 
> > Also Thomas gave a +1 on the changing of lookup() to insert(). So there
> > too, unless more objections arise, that change should go in.

Please make sure to rename also all the comments about lookup to insert in 
KoGenStyle.{h,cpp}

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]