[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KoGenStyle(s) cleanup
From:       Jaroslaw S <kexipl () gmail ! com>
Date:       2010-03-08 13:12:36
Message-ID: 56a746381003080512g78a93adcg87d8de8dc49c15de () mail ! gmail ! com
[Download RAW message or body]

On 8 March 2010 14:06, Jos van den Oever <Jos.van.den.Oever@kogmbh.com> wrote:
> On Monday 08 March 2010 13:13:32 Jos van den Oever wrote:
>> On Monday 08 March 2010 13:02:45 Thomas Zander wrote:
>> >     enum values all currently are consistently starting with 'Style' Or
>> >
>> > StyleAuto, your change makes this inconsistent AFAICT. Starting and
>> > ending with consistent wording is nowhere near as logical as only
>> > starting with a consistent wording.
>>
>> No, the changes makes them consistently end with Auto. It's debatable if
>> AutoStyle* would be better than Style*Auto, but the current change
>> *improves* consistency.
> Just chatted with TZander. We both like the AutoStyle* naming. If Jaroslaw
> agrees (and nobody else objects) that would be a solution.
>
> Also Thomas gave a +1 on the changing of lookup() to insert(). So there too,
> unless more objections arise, that change should go in.

OK, will try tonight.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & KOffice (http://www.kexi-project.org, http://www.koffice.org)
 KDE Software Development Platform on MS Windows (http://windows.kde.org)
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]