[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: transparent background
From:       "Sebastian Sauer" <mail () dipe ! org>
Date:       2010-03-03 23:01:49
Message-ID: 20100303230149.15905.11273 () localhost
[Download RAW message or body]



> On 2010-03-03 19:44:08, Thomas Zander wrote:
> > QColor can be valid and be transparant, the application that uses an invalid \
> > color to specify transparancy can thus easily be changed to either; a) use a \
> > QColor with full transparancy b) not use a KoBackground in the first place.
> 
> Sebastian Sauer wrote:
> yes, but such transparent QColors are not painted black while invalid QColors are \
> painted as black colors. Its easy to fix that in KChart but I provided the patch \
> above cause I think that a more general solution where invalid QColor == \
> transparent QColor would make more sense... you do not agree or how to understand \
> the comment? 
> 
> Thomas Zander wrote:
> The comment means I think that kchart should be fixed first.  I personally would \
> suggest printing a warning on passing in an invalid color since its a bug in the \
> usage of the class. Not in the class itself. 
> The assumption that the user meant to not draw anything instead of draw black is an \
> assumption I don't think belongs in this class.

Fix for kchart was committed with r1098569. I think an invalid color means no color \
and not black, imho rather locial. Anyway, its fixed for kchart now.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3096/#review4350
-----------------------------------------------------------


On 2010-03-03 19:07:41, Sebastian Sauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3096/
> -----------------------------------------------------------
> 
> (Updated 2010-03-03 19:07:41)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> KChart sets a transparent background using an invalid QColor. This indeed is not \
> transparent but a black background. This patch fixes that and does not draw thw \
> background if an invalid background color was defined. 
> 
> Diffs
> -----
> 
> trunk/koffice/libs/flake/KoColorBackground.cpp 1098412 
> 
> Diff: http://reviewboard.kde.org/r/3096/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sebastian
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]