[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: KoGenStyle(s) cleanup
From: "Jaroslaw Staniek" <staniek () kde ! org>
Date: 2010-03-03 13:22:46
Message-ID: 20100303132246.30732.70080 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3090/
-----------------------------------------------------------
(Updated 2010-03-03 13:22:46.466309)
Review request for KOffice.
Changes
-------
added note about KoGenStyle::N_NumTypes
Summary (updated)
-------
NOTE: the patch only contains changes to KoGenStyle*.* files. Required updates for \
other KOffice code shall be provided after this patch is approved.
* KoGenStyle::Type cleanup:
- renamed StyleUser to StyleParagraph
- renamed StyleAuto to StyleParagraphAuto
- move the 'Auto' to the end for the table style families
* KoGenStyles::Flags made QFlags
* KoGenStyles::lookup() -> KoGenStyles::insert()
* move KoGenStyle::isEmpty() code to .cpp
* use constFind(), constBegin(), constEnd() for iterators if possible
* made some methods const
* introduced KoGenStyles::StylesPlacement for saving odf and inserting raw styles.
* insertRawStyles() replaces 4 methods. saveOdfStyles() replaces 4 other methods.
* KoGenStyle::N_NumTypes -> KoGenStyle::N_NumPropertyTypes
* added KoGenStyle::N_NumTypes
* KoGenStyles: StyleArray -> QList<KoGenStyles::NamedStyle>
* KoGenStyles: NameMap typedef removed, using just QSet<QString> is clear
* To minimize size of the patch, I am noting down remaining possible TODOs:
TODO 1: make KoGenStyle implicitly shared: optimizes and fixes risk of BIC changes \
because of m_properties
TODO 2: add QList<KoGenStyles::NamedStyle> \
KoGenStyles::Private::stylesForTypes[KoGenStyle::N_NumTypes] for optimizing static \
QList<KoGenStyles::NamedStyle> styles(const QSet<QString>& names, KoGenStyle::Type \
type)
TODO 3: replace QSet<QString> KoGenStyles::Private::styleNames with QMap<QString, \
KoGenStyle*> KoGenStyles::Private::styles
for optimizing const KoGenStyle* KoGenStyles::style(const QString& name) const
TODO 4: implement qDebug() for KoGenStyles instead of dump()
TODO 5: implement qDebug() for KoGenStyle instead of printDebug()
TODO 6: rename to KoOdfStyle(s)
Diffs
-----
trunk/koffice/libs/odf/KoGenStyle.h 1097689
trunk/koffice/libs/odf/KoGenStyle.cpp 1097689
trunk/koffice/libs/odf/KoGenStyles.h 1097689
trunk/koffice/libs/odf/KoGenStyles.cpp 1097689
Diff: http://reviewboard.kde.org/r/3090/diff
Testing
-------
builds, checked if there's no change in semantics
Thanks,
Jaroslaw
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic