[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Generalise filter regession test script
From:       "Shaheed Haque" <srhaque () theiet ! org>
Date:       2010-03-03 10:08:08
Message-ID: 20100303100808.26348.16585 () localhost
[Download RAW message or body]



> On 2010-03-03 08:42:04, vandenoever wrote:
> > /trunk/tests/kofficetests/import/powerpoint/runtests.sh, line 16
> > <http://reviewboard.kde.org/r/3089/diff/1/?file=20293#file20293line16>
> > 
> > Please leave two examples where a different conversion tool is used.
> > 

That is still there, under the description of "-c". But, I'll add a reference to that \
in the intro.


> On 2010-03-03 08:42:04, vandenoever wrote:
> > /trunk/tests/kofficetests/import/powerpoint/runtests.sh, line 35
> > <http://reviewboard.kde.org/r/3089/diff/1/?file=20293#file20293line35>
> > 
> > typeset is synonym with declare but considered obsolete
> > 
> > typeset/declare was new to me and perhaps not widely know. A comment stating that \
> > you are defining constant global variables would be helpful. 

I don't see that in the man page, but OK, I changed to "declare".


> On 2010-03-03 08:42:04, vandenoever wrote:
> > /trunk/tests/kofficetests/import/powerpoint/runtests.sh, line 147
> > <http://reviewboard.kde.org/r/3089/diff/1/?file=20293#file20293line147>
> > 
> > Putting these urls in a variable at the top of the file would be a good idea.
> > 

Done


> On 2010-03-03 08:42:04, vandenoever wrote:
> > /trunk/tests/kofficetests/import/powerpoint/runtests.sh, line 169
> > <http://reviewboard.kde.org/r/3089/diff/1/?file=20293#file20293line169>
> > 
> > jing is not an alias or command for everyone. Best is to look for jing, and if it \
> > does not exists use "java -jar $JINGJAR". If that fails, print an error message.

I hope you like the new treatment I just added, using a new -j option.


- Shaheed


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3089/#review4344
-----------------------------------------------------------


On 2010-03-02 22:00:45, Shaheed Haque wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3089/
> -----------------------------------------------------------
> 
> (Updated 2010-03-02 22:00:45)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> -Update the script to support tests which are not in one flat directory.
> -Adapt Makefile to new script.
> 
> 
> Diffs
> -----
> 
> /trunk/tests/kofficetests/import/powerpoint/Makefile 1098000 
> /trunk/tests/kofficetests/import/powerpoint/runtests.sh 1098000 
> 
> Diff: http://reviewboard.kde.org/r/3089/diff
> 
> 
> Testing
> -------
> 
> Existing ppt tests seem to run (though some fail).
> 
> 
> Thanks,
> 
> Shaheed
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]