[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: [api] PathToolOptionWidget::setSelectionType()
From:       Jaroslaw S <kexipl () gmail ! com>
Date:       2010-03-02 11:11:12
Message-ID: 56a746381003020311nda66190j64549897e4ba68d9 () mail ! gmail ! com
[Download RAW message or body]

On 2 March 2010 10:45, Thomas Zander <zander@kde.org> wrote:
> On Tuesday 2. March 2010 00.03.42 Jaroslaw Staniek wrote:
>> Hi,
>> In flake/tools/PathToolOptionWidget.h:
>> Shouldn't int be replaced with Type in
>> PathToolOptionWidget::setSelectionType(int type)?
>>
>> (this change would require updates in flake/tools/KoPathTool.h)
>
> Sounds like a great idea to me.
>
> This would involve moving the Type enum to the KoPathTool.h (since that one is
> installed) and make it use the Q_DECLARE_FLAGS macro. After this you can
> replace the int with the flags. :)

OK

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & KOffice (http://www.kexi-project.org, http://www.koffice.org)
 KDE Software Development Platform on MS Windows (http://windows.kde.org)
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]