[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: office art implementation in the kword filter
From:       "C. Boemann" <cbo () boemann ! dk>
Date:       2010-02-27 9:56:45
Message-ID: 201002271056.45407.cbo () boemann ! dk
[Download RAW message or body]

commited

On Friday 26 February 2010 09:35:33 Nohaj Miroslav wrote:
> OK then, those two files (the diff and the .h file) from my previous mail
>  should be OK (also the alignment was finished there). So if enyone else
>  could try to apply the diff and see the if lines are displayed OK, then
>  that should be the last step before the commit...
> 
> BR,
>  Miroslav
> 
> 
> 
> -----Original Message-----
> From: C. Boemann [mailto:cbo@boemann.dk]
> Sent: 25. februára 2010 19:45
> To: For developer's discussion about KOffice
> Subject: Re: office art implementation in the kword filter
> 
> Well reviewboard or mailinglist review accomplish the same thing. I am
> satisfied with the code now, so if you believe it solves the thing you
>  wanted it to solve then let us commit it.
> 
> I assume you don't have an account yet so just give me the diff you want to
> have committed and I'll do it for you.
> 
> I also think that once this is in you have proved that you are ready to
>  have you own account. so we should get that moving too.
> 
> best regards
> Casper
> 
> On Thursday 25 February 2010 16:51:04 Nohaj Miroslav wrote:
> > Hello,
> >
> > I did some coding convention fixes as you recommended, removed the
> 
> changes
> 
> >  to global.h - see attachment. Should I post to KDE's review board now?
> >
> > BR,
> >   Miroslav
> >
> >
> >
> > -----Original Message-----
> > From: C. Boemann [mailto:cbo@boemann.dk]
> > Sent: 25. februára 2010 15:12
> > To: For developer's discussion about KOffice
> > Subject: Re: office art implementation in the kword filter
> >
> > hi
> >
> > you still need to remove the change to global.h before we can commit
> >
> > you also need to follow the hacking style for the new code you write
> >  (opening braces and spaces to name a few issues)
> >
> > In officeArtLine() I'm wondering why you use your own numbering of
> > automatic styles instead of using the lib to generate the numbered name
> 
> for
> 
> > you.
> >
> > but still, on the overall it looks correct
> >
> > best regards
> > Casper
> >
> >  On Thursday 25 February 2010 10:04:55 Nohaj Miroslav wrote:
> > > The diff before astyle (formating) is in the attachment (if anybody
> > > would like to take a look).
> > >
> > > BR,
> > >  Miroslav
> > >
> > >
> > >
> > > -----Original Message-----
> > > From: Nohaj Miroslav [mailto:miroslav.nohaj@ixonos.com]
> > > Sent: 24. februára 2010 15:57
> > > To: For developer's discussion about KOffice
> > > Subject: RE: office art implementation in the kword filter
> > >
> > > > The huge formatting change in parser9x.* kind of hides if you have
> 
> one
> 
> > > > any change - i' m assuming you haven't any one liners hidden in
> > > > there. I think i found the big 20+ lines additions.
> > >
> > > Yes, some complete methods were added. The formatting changes 
are
> >
> > probably
> >
> > >  because I used 'astyle' for formatting the sources (I had it
> 
> recommended
> 
> > >  for fixing the most of the coding convention issues).
> > >
> > > > But please provide first a diff for general indenting fixes, and then
> > > > a diff for your actual changes.
> > >
> > > OK, I will revert to the files not processed by 'astyle'.
> > >
> > > Best regards,
> > >   Miroslav
> > >
> > >
> > > _______________________________________________
> > > koffice-devel mailing list
> > > koffice-devel@kde.org
> > > https://mail.kde.org/mailman/listinfo/koffice-devel
> >
> > _______________________________________________
> > koffice-devel mailing list
> > koffice-devel@kde.org
> > https://mail.kde.org/mailman/listinfo/koffice-devel
> 
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
> 
> 
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
> 
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]