[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Picture bullets
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-02-21 8:11:04
Message-ID: 20100221081104.7341.45696 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3031/#review4236
-----------------------------------------------------------
All ok from my side.
trunk/koffice/libs/kotext/styles/KoListLevelProperties.h
<http://reviewboard.kde.org/r/3031/#comment3771>
The comments still say 'picture' maybe call that 'image' too?
trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp
<http://reviewboard.kde.org/r/3031/#comment3770>
Just this minor nag; I would like to pass the KoImageData object instead of an anonymous \
qint64 that nobody will understand where it comes from. Passing in a KoImageData object makes \
the API much clearer.
- Thomas
On 2010-02-20 23:34:51, Casper Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3031/
> -----------------------------------------------------------
>
> (Updated 2010-02-20 23:34:51)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Support for picture bullets
> - load from odf
> - use image collection
> - however this means a a shapeLoadingContext is required in many places instead of a \
> odfLoadingContext
> the patch doesn't include relatede changes (on liners) in every application
> the path doesn't include the painting code either (though i have it working :) )
>
>
> Diffs
> -----
>
> trunk/koffice/libs/kotext/KoTextDocumentLayout.h 1090166
> trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1090166
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.h 1090166
> trunk/koffice/libs/kotext/opendocument/KoTextSharedLoadingData.cpp 1090166
> trunk/koffice/libs/kotext/opendocument/tests/TestLoading.cpp 1090166
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.h 1090166
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1090166
> trunk/koffice/libs/kotext/styles/KoListStyle.h 1090166
> trunk/koffice/libs/kotext/styles/KoListStyle.cpp 1090166
>
> Diff: http://reviewboard.kde.org/r/3031/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Casper
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic