From koffice-devel  Thu Feb 18 21:01:25 2010
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: Thu, 18 Feb 2010 21:01:25 +0000
To: koffice-devel
Subject: Re: Review Request: Load the page-layout-properties background
Message-Id: <20100218210125.879.48755 () localhost>
X-MARC-Message: https://marc.info/?l=koffice-devel&m=126652694111872



> On 2010-02-18 16:40:04, Thomas Zander wrote:
> > Great patch!
> > I have found some bugs that I would appreciate fixing before committing ;)
> > 
> > Thanks

All KWPageStyle suggestsion are incorporated.


> On 2010-02-18 16:40:04, Thomas Zander wrote:
> > /trunk/koffice/kword/part/KWOdfLoader.cpp, line 198
> > <http://reviewboard.kde.org/r/3003/diff/1/?file=19649#file19649line198>
> >
> >     Out of curiosity, why is this line needed?  IIRC pagestyle "Standard" is not loaded from the ODF.

It's more or less the main thing: the page style actually doesn't seem to be set on the main text frame anywhere, so by setting it here, we make sure it is actually used.


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3003/#review4200
-----------------------------------------------------------


On 2010-02-18 15:57:06, Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3003/
> -----------------------------------------------------------
> 
> (Updated 2010-02-18 15:57:06)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch loads the background page style property in KWPageStyle. It set the page style on the main text frameset and extends KWTextFrameSet to set the background on the underlying text shape. 
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/kword/part/KWOdfLoader.cpp 1091790 
>   /trunk/koffice/kword/part/KWPageStyle.h 1091790 
>   /trunk/koffice/kword/part/KWPageStyle.cpp 1091790 
>   /trunk/koffice/kword/part/KWPageStyle_p.h 1091790 
>   /trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1091790 
> 
> Diff: http://reviewboard.kde.org/r/3003/diff
> 
> 
> Testing
> -------
> 
> Test with test document oow_page_background_color.odt (should be in kofficetests), It shows the main text frame in the specified background color just like OpenOffice.
> 
> 
> Thanks,
> 
> Boudewijn
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel