[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Load the page-layout-properties background
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-02-18 16:39:59
Message-ID: 20100218163959.27883.88296 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3003/#review4200
-----------------------------------------------------------


Great patch!
I have found some bugs that I would appreciate fixing before committing ;)

Thanks


/trunk/koffice/kword/part/KWOdfLoader.cpp
<http://reviewboard.kde.org/r/3003/#comment3726>

    Out of curiosity, why is this line needed?  IIRC pagestyle "Standard" is not \
loaded from the ODF.



/trunk/koffice/kword/part/KWPageStyle.cpp
<http://reviewboard.kde.org/r/3003/#comment3721>

    currently the background is refcounted I think you should defer it before \
deleting.



/trunk/koffice/kword/part/KWPageStyle.cpp
<http://reviewboard.kde.org/r/3003/#comment3722>

    deref and possible delete of background can avoid a leak here.



/trunk/koffice/kword/part/KWPageStyle.cpp
<http://reviewboard.kde.org/r/3003/#comment3723>

    this clear can be removed, the constructor of KWPageStylePrivate also calls it. \
No need to call it twice.



/trunk/koffice/kword/part/KWPageStyle.cpp
<http://reviewboard.kde.org/r/3003/#comment3724>

    there is no need to init a QExplicitlySharedDataPointer with zero, please remove \
this line.



/trunk/koffice/kword/part/KWPageStyle.cpp
<http://reviewboard.kde.org/r/3003/#comment3725>

    I would suggest to just set 'd->background' to zero. Transparant is the default.


- Thomas


On 2010-02-18 15:57:06, Boudewijn Rempt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3003/
> -----------------------------------------------------------
> 
> (Updated 2010-02-18 15:57:06)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch loads the background page style property in KWPageStyle. It set the page \
> style on the main text frameset and extends KWTextFrameSet to set the background on \
> the underlying text shape.  
> 
> Diffs
> -----
> 
> /trunk/koffice/kword/part/KWOdfLoader.cpp 1091790 
> /trunk/koffice/kword/part/KWPageStyle.h 1091790 
> /trunk/koffice/kword/part/KWPageStyle.cpp 1091790 
> /trunk/koffice/kword/part/KWPageStyle_p.h 1091790 
> /trunk/koffice/kword/part/frames/KWTextFrameSet.cpp 1091790 
> 
> Diff: http://reviewboard.kde.org/r/3003/diff
> 
> 
> Testing
> -------
> 
> Test with test document oow_page_background_color.odt (should be in kofficetests), \
> It shows the main text frame in the specified background color just like \
> OpenOffice. 
> 
> Thanks,
> 
> Boudewijn
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]