'Re: Review Request: RDF support for KWord.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: RDF support for KWord.
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-02-11 9:45:03
Message-ID: 20100211094503.32247.2760 () localhost
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2611/#review4124
-----------------------------------------------------------

Missing the new files in this diff, but found some issues in the changes you might be \
interested in anyway :)

/trunk/koffice/kword/part/KWView.h
<http://reviewboard.kde.org/r/2611/#comment3677>

    Pass QString by const ref, please.

/trunk/koffice/libs/kotext/KoInlineObject.cpp
<http://reviewboard.kde.org/r/2611/#comment3676>

    you can remove the 'if' statement. its perfectly fine to delete a zero pointer.

/trunk/koffice/libs/kotext/KoTextOdfSaveHelper.cpp
<http://reviewboard.kde.org/r/2611/#comment3678>

    please don't use an m_ prefix for variable names in the Private class.
    Using rdfModel instead of m_rdfModel is more consistent.

/trunk/koffice/libs/kotext/KoTextPaste.cpp
<http://reviewboard.kde.org/r/2611/#comment3679>

    since you add the keyword 'bool' in front of this 'ok' this check will have no \
effect.  Looks like a bug.

/trunk/koffice/libs/kotext/opendocument/KoTextLoader.h
<http://reviewboard.kde.org/r/2611/#comment3680>

    Please pass in the argument QString with a const ref (the returned one is fine.)

/trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp
<http://reviewboard.kde.org/r/2611/#comment3681>

    very minor issue; can you start from 1 please? :)

- Thomas

On 2010-02-11 08:03:08, Ben Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2611/
> -----------------------------------------------------------
> 
> (Updated 2010-02-11 08:03:08)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> RDF support for KWord. As can be seen from the files, KoDocumentRDF is the main new \
> addition, with changes to other areas for load/save, copy/paste of RDF enriched \
> document elements. For interaction with RDF one can either use the triple model \
> directly through KoDocumentRDF or obtain various "semantic items" from KoDocRDF. \
> These semantic items (semitems) come from the RDF triples and go back to them. The \
> semitems are a convenience allowing interaction at a more conceptual level, for \
> example as a single "Contact" instead of remembering the 10+ constituent triples. 
> Instead of looking at lower level issues, I'm hoping that initial comments will \
> focus more on the errors and/or misuses I've made as a newbie to KOffice hacking. \
> Once I fix those up we can move to a more serious review? 
> There is a KoDocument::textEditor() method which I added temporarily and have \
> removed most references to. The two main places that use it are after you edit a \
> semantic item a slot() in KoDocumentRDF grabs this->document()->textEditor() to \
> update the semitem's text in the document to reflect your changes. This could be \
> mitigated by adding a slot() in KWDocument that does the same call but has access \
> to the KoTextEditor. The one problem area is in the "File/Document Information" \
> window where I allow the default stylesheets to be set. The best solution in my \
> mind here is once again signals/slots, the infodialog could tell the KoDocumentRDF \
> what to do which through sig/slots could send the information to KWDocument to \
> cause a relayout of semitems using the new stylesheet preference. 
> For ideas of what the patch allows, see my recent blog entries:
> http://monkeyiq.blogspot.com/
> 
> A few known issues:
> 
> * Assumption that marble will be found, there are some ifdefs but
> I should improve those and perform a full compile with marble-dev
> explicitly hidden
> 
> * Two kDebug() numbers used but unreserved as yet.
> 30015        koffice (rdf)
> 30016        koffice (rdf semantic)
> 
> * I will be fixing a few minor bugs in KoDocumentRDFEditWidget during 
> the review process, these should be fairly contained changes.
> 
> * Some additions for KoBookmark copy and paste. If you select only half the
> text for the KoBookmark and copy, with this patch, it will now produce a correct \
> ODF file. On paste, KoTextLoader::createUniqBookmarkName() is used to ensure that
> a new bookmark name is made, while respecting that the bookmark-end wants
> the previous unique bookmark name instead of the next in series.
> 
> * After editing a semantic item or applying a stylesheet I'm getting a 
> green highlight now that wasn't there on the 23rd of December. 
> The 23rd was my previous rebase.
> 
> 
> Diffs
> -----
> 
> /trunk/koffice/CMakeLists.txt 1088530 
> /trunk/koffice/kword/part/CMakeLists.txt 1088530 
> /trunk/koffice/kword/part/KWDocument.cpp 1088530 
> /trunk/koffice/kword/part/KWOdfLoader.cpp 1088530 
> /trunk/koffice/kword/part/KWOdfWriter.cpp 1088530 
> /trunk/koffice/kword/part/KWView.h 1088530 
> /trunk/koffice/kword/part/KWView.cpp 1088530 
> /trunk/koffice/kword/part/kword.rc 1088530 
> /trunk/koffice/libs/kotext/CMakeLists.txt 1088530 
> /trunk/koffice/libs/kotext/KoBookmark.cpp 1088530 
> /trunk/koffice/libs/kotext/KoInlineObject.h 1088530 
> /trunk/koffice/libs/kotext/KoInlineObject.cpp 1088530 
> /trunk/koffice/libs/kotext/KoInlineObject_p.h 1088530 
> /trunk/koffice/libs/kotext/KoText.h 1088530 
> /trunk/koffice/libs/kotext/KoTextDocument.h 1088530 
> /trunk/koffice/libs/kotext/KoTextDrag.cpp 1088530 
> /trunk/koffice/libs/kotext/KoTextEditor.cpp 1088530 
> /trunk/koffice/libs/kotext/KoTextOdfSaveHelper.h 1088530 
> /trunk/koffice/libs/kotext/KoTextOdfSaveHelper.cpp 1088530 
> /trunk/koffice/libs/kotext/KoTextPaste.h 1088530 
> /trunk/koffice/libs/kotext/KoTextPaste.cpp 1088530 
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.h 1088530 
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1088530 
> /trunk/koffice/libs/kotext/opendocument/KoTextSharedSavingData.h 1088530 
> /trunk/koffice/libs/kotext/opendocument/KoTextSharedSavingData.cpp 1088530 
> /trunk/koffice/libs/kotext/opendocument/KoTextWriter.cpp 1088530 
> /trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1088530 
> /trunk/koffice/libs/kotext/styles/KoTableCellStyle.h 1088530 
> /trunk/koffice/libs/main/CMakeLists.txt 1088530 
> /trunk/koffice/libs/main/KoDocument.h 1088530 
> /trunk/koffice/libs/main/KoDocument.cpp 1088530 
> /trunk/koffice/libs/main/KoDocumentInfoDlg.h 1088530 
> /trunk/koffice/libs/main/KoDocumentInfoDlg.cpp 1088530 
> /trunk/koffice/libs/main/KoMainWindow.cpp 1088530 
> /trunk/koffice/libs/odf/KoXmlNS.h 1088530 
> /trunk/koffice/libs/odf/KoXmlNS.cpp 1088530 
> /trunk/koffice/plugins/textshape/CMakeLists.txt 1088530 
> /trunk/koffice/plugins/textshape/TextTool.cpp 1088530 
> /trunk/koffice/plugins/textshape/commands/TextPasteCommand.cpp 1088530 
> 
> Diff: http://reviewboard.kde.org/r/2611/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ben
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 