-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2634/#review3974
-----------------------------------------------------------

Ship it!


Looks good. OO is still not able to load the file but that looks like an OO bug.

- Thorsten


On 2010-01-22 19:53:29, Jan Hambrecht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2634/
> -----------------------------------------------------------
> 
> (Updated 2010-01-22 19:53:29)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> This patch implements loading and saving of path data of a connector shape as defined by ODF 1.2. Connector shapes not connected completely with both ends of the connector to an existing shape can preserve their path data by saving it to a svg:d attribute plus an additional svg:viewBox attribute. The exact details are properly underdefined in the ODF specification, as usual. I implemented it the way which made most sense to me. Note that OOo seems to not save the requiered svg:viewBox attribute, but the code does deal with that case sufficiently.
> In order to reuse some existing code from KoPathShape I moved the private KoPathShape::map function to the shared Private class. Also I added a default parameter value to the KoPathShape::toString function as it seems in most cases a identiy matrix was passed anyway.
> 
> 
> Diffs
> -----
> 
>   /trunk/koffice/libs/flake/KoConnectionShape.h 1078714 
>   /trunk/koffice/libs/flake/KoConnectionShape.cpp 1078714 
>   /trunk/koffice/libs/flake/KoConnectionShapeLoadingUpdater.cpp 1078714 
>   /trunk/koffice/libs/flake/KoConnectionShape_p.h 1078714 
>   /trunk/koffice/libs/flake/KoPathShape.h 1078714 
>   /trunk/koffice/libs/flake/KoPathShape.cpp 1078714 
> 
> Diff: http://reviewboard.kde.org/r/2634/diff
> 
> 
> Testing
> -------
> 
> I tested with an OOo exported odp file which contained 3 different unconnected connector shapes. The additional saved attributes do validate when checking with the online ODF validator (there are some errors thrown from other elements/attributes in our files, which do show some errors on the validator side, i.e. regarding draw:layer-set element).
> 
> 
> Thanks,
> 
> Jan
> 
>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel