[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: KSpread: Creating thumbnail while saving the file
From:       "Marijn Kruisselbrink" <m.kruisselbrink () student ! tue ! nl>
Date:       2010-01-29 10:01:31
Message-ID: 20100129100131.8357.47043 () localhost
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2660/#review3957
-----------------------------------------------------------



trunk/koffice/kspread/part/Doc.cpp
<http://reviewboard.kde.org/r/2660/#comment3346>

    here you remove the only palce paintCellRegions is called, why not remove that \
entire method then, instead of leaving it empty?


- Marijn


On 2010-01-21 09:04:06, Mani Chandrasekar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2660/
> -----------------------------------------------------------
> 
> (Updated 2010-01-21 09:04:06)
> 
> 
> Review request for KOffice.
> 
> 
> Summary
> -------
> 
> Attached patch would create thumbnail of specified size and return a QPixmap.
> 
> This will be used to create thumbnail(preview) while saving the document. And \
> removed some obsolete code. 
> 
> Diffs
> -----
> 
> trunk/koffice/kspread/Sheet.h 1070199 
> trunk/koffice/kspread/Sheet.cpp 1070199 
> trunk/koffice/kspread/SheetPrint.h 1070199 
> trunk/koffice/kspread/SheetPrint.cpp 1070199 
> trunk/koffice/kspread/part/Doc.cpp 1070199 
> 
> Diff: http://reviewboard.kde.org/r/2660/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mani
> 
> 

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]