[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: RDF support for KWord.
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-01-28 18:18:06
Message-ID: 20100128181806.19187.7013 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2611/#review3945
-----------------------------------------------------------
The naming style for abbreviated terminology is to use only one capital letter (Url, \
Ftp, etc) so the classes and methods with the abbreviation 'RDF' should be uppercased \
like this; 'Rdf'. Please rename KoDocumentRDF to KoDocumentRdf
I still see a lot of coding style issues, please fix those. \
http://techbase.kde.org/Policies/Kdelibs_Coding_Style I repeated some issues and with \
the coding style being hard to read I didn't go through the whole patch. Please \
re-submit one thats cleaned up. Thanks
/trunk/koffice/CMakeLists.txt
<http://reviewboard.kde.org/r/2611/#comment3322>
Soprano is not optional, is it? But this cmake call will not stop the build if \
soprano is not found AFAICT.
/trunk/koffice/CMakeLists.txt
<http://reviewboard.kde.org/r/2611/#comment3323>
KOffice can't depend on marble. Not optionally or otherwise.
/trunk/koffice/cmake/modules/FindSoprano.cmake
<http://reviewboard.kde.org/r/2611/#comment3324>
Missing license header
/trunk/koffice/kword/part/CMakeLists.txt
<http://reviewboard.kde.org/r/2611/#comment3325>
I think this should be merged with the line 2 lines up.
/trunk/koffice/libs/flake/KoResourceManager.cpp
<http://reviewboard.kde.org/r/2611/#comment3326>
Please remove this method; flake can't depend on komain (where KoDocumentRDF is)
- Thomas
On 2010-01-28 12:35:52, Ben Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2611/
> -----------------------------------------------------------
>
> (Updated 2010-01-28 12:35:52)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> RDF support for KWord. As can be seen from the files, KoDocumentRDF is the main new \
> addition, with changes to other areas for load/save, copy/paste of RDF enriched \
> document elements. For interaction with RDF one can either use the triple model \
> directly through KoDocumentRDF or obtain various "semantic items" from KoDocRDF. \
> These semantic items (semitems) come from the RDF triples and go back to them. The \
> semitems are a convenience allowing interaction at a more conceptual level, for \
> example as a single "Contact" instead of remembering the 10+ constituent triples.
> Instead of looking at lower level issues, I'm hoping that initial comments will \
> focus more on the errors and/or misuses I've made as a newbie to KOffice hacking. \
> Once I fix those up we can move to a more serious review?
> There is a KoDocument::textEditor() method which I added temporarily and have \
> removed most references to. The two main places that use it are after you edit a \
> semantic item a slot() in KoDocumentRDF grabs this->document()->textEditor() to \
> update the semitem's text in the document to reflect your changes. This could be \
> mitigated by adding a slot() in KWDocument that does the same call but has access \
> to the KoTextEditor. The one problem area is in the "File/Document Information" \
> window where I allow the default stylesheets to be set. The best solution in my \
> mind here is once again signals/slots, the infodialog could tell the KoDocumentRDF \
> what to do which through sig/slots could send the information to KWDocument to \
> cause a relayout of semitems using the new stylesheet preference.
> For ideas of what the patch allows, see my recent blog entries:
> http://monkeyiq.blogspot.com/
>
> A few known issues:
>
> * Assumption that marble will be found, there are some ifdefs but
> I should improve those and perform a full compile with marble-dev
> explicitly hidden
>
> * Two kDebug() numbers used but unreserved as yet.
> 30015 koffice (rdf)
> 30016 koffice (rdf semantic)
>
> * I will be fixing a few minor bugs in KoDocumentRDFEditWidget during
> the review process, these should be fairly contained changes.
>
> * Some additions for KoBookmark copy and paste. If you select only half the
> text for the KoBookmark and copy, with this patch, it will now produce a correct \
> ODF file. On paste, KoTextLoader::createUniqBookmarkName() is used to ensure that
> a new bookmark name is made, while respecting that the bookmark-end wants
> the previous unique bookmark name instead of the next in series.
>
> * After editing a semantic item or applying a stylesheet I'm getting a
> green highlight now that wasn't there on the 23rd of December.
> The 23rd was my previous rebase.
>
>
> Diffs
> -----
>
> /trunk/koffice/CMakeLists.txt 1079848
> /trunk/koffice/cmake/modules/FindSoprano.cmake PRE-CREATION
> /trunk/koffice/kword/part/CMakeLists.txt 1079848
> /trunk/koffice/kword/part/KWDocument.cpp 1079848
> /trunk/koffice/kword/part/KWOdfLoader.cpp 1079848
> /trunk/koffice/kword/part/KWOdfWriter.cpp 1079848
> /trunk/koffice/kword/part/KWView.h 1079848
> /trunk/koffice/kword/part/KWView.cpp 1079848
> /trunk/koffice/kword/part/dockers/KWRDFDocker.h PRE-CREATION
> /trunk/koffice/kword/part/dockers/KWRDFDocker.cpp PRE-CREATION
> /trunk/koffice/kword/part/dockers/KWRDFDocker.ui PRE-CREATION
> /trunk/koffice/kword/part/dockers/KWRDFDockerFactory.h PRE-CREATION
> /trunk/koffice/kword/part/dockers/KWRDFDockerFactory.cpp PRE-CREATION
> /trunk/koffice/kword/part/dockers/KWRDFDockerTree.h PRE-CREATION
> /trunk/koffice/kword/part/dockers/KWRDFDockerTree.cpp PRE-CREATION
> /trunk/koffice/kword/part/frames/KWTextDocumentLayout.cpp 1079848
> /trunk/koffice/kword/part/kword.rc 1079848
> /trunk/koffice/libs/flake/KoResourceManager.h 1079848
> /trunk/koffice/libs/flake/KoResourceManager.cpp 1079848
> /trunk/koffice/libs/kotext/CMakeLists.txt 1079848
> /trunk/koffice/libs/kotext/KoBookmark.cpp 1079848
> /trunk/koffice/libs/kotext/KoInlineObject.h 1079848
> /trunk/koffice/libs/kotext/KoInlineObject.cpp 1079848
> /trunk/koffice/libs/kotext/KoInlineObject_p.h 1079848
> /trunk/koffice/libs/kotext/KoTextBlockData.cpp 1079848
> /trunk/koffice/libs/kotext/KoTextDocument.h 1079848
> /trunk/koffice/libs/kotext/KoTextDrag.cpp 1079848
> /trunk/koffice/libs/kotext/KoTextEditor.cpp 1079848
> /trunk/koffice/libs/kotext/KoTextInlineRDF.h PRE-CREATION
> /trunk/koffice/libs/kotext/KoTextInlineRDF.cpp PRE-CREATION
> /trunk/koffice/libs/kotext/KoTextMeta.h PRE-CREATION
> /trunk/koffice/libs/kotext/KoTextMeta.cpp PRE-CREATION
> /trunk/koffice/libs/kotext/KoTextOdfSaveHelper.h 1079848
> /trunk/koffice/libs/kotext/KoTextOdfSaveHelper.cpp 1079848
> /trunk/koffice/libs/kotext/KoTextPaste.h 1079848
> /trunk/koffice/libs/kotext/KoTextPaste.cpp 1079848
> /trunk/koffice/libs/kotext/KoTextRDFCore.h PRE-CREATION
> /trunk/koffice/libs/kotext/KoTextRDFCore.cpp PRE-CREATION
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.h 1079848
> /trunk/koffice/libs/kotext/opendocument/KoTextLoader.cpp 1079848
> /trunk/koffice/libs/kotext/opendocument/KoTextSharedSavingData.h 1079848
> /trunk/koffice/libs/kotext/opendocument/KoTextSharedSavingData.cpp 1079848
> /trunk/koffice/libs/kotext/opendocument/KoTextWriter.cpp 1079848
> /trunk/koffice/libs/kotext/styles/KoCharacterStyle.h 1079848
> /trunk/koffice/libs/kotext/styles/KoTableCellStyle.h 1079848
> /trunk/koffice/libs/main/CMakeLists.txt 1079848
> /trunk/koffice/libs/main/KoDocument.h 1079848
> /trunk/koffice/libs/main/KoDocument.cpp 1079848
> /trunk/koffice/libs/main/KoDocumentInfoDlg.h 1079848
> /trunk/koffice/libs/main/KoDocumentInfoDlg.cpp 1079848
> /trunk/koffice/libs/main/KoMainWindow.cpp 1079848
> /trunk/koffice/libs/main/rdf/InsertSemanticObjectActionBase.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/InsertSemanticObjectActionBase.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/InsertSemanticObjectCreateAction.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/InsertSemanticObjectCreateAction.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/InsertSemanticObjectReferenceAction.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/InsertSemanticObjectReferenceAction.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoChangeTrackerDisabledRAII.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoChangeTrackerDisabledRAII.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoDocumentRDF.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoDocumentRDF.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoDocumentRDFEditWidget.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoDocumentRDFEditWidget.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoDocumentRDFEditWidget.ui PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoDocumentRDF_p.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoSopranoTableModel.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoSopranoTableModel.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoSopranoTableModelDelegate.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/KoSopranoTableModelDelegate.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFCalendarEvent.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFCalendarEvent.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFCalendarEventEditWidget.ui PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFCalendarEventTreeWidgetItem.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFCalendarEventTreeWidgetItem.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFFoaF.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFFoaF.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFFoaFEditWidget.ui PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFFoaFTreeWidgetItem.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFFoaFTreeWidgetItem.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFForward.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocation.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocation.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocationEditWidget.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocationEditWidget.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocationEditWidget.ui PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocationTreeWidgetItem.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocationTreeWidgetItem.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFLocationViewWidget.ui PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFPrefixMapping.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFPrefixMapping.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticItem.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticItem.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticItemViewSite.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticItemViewSite.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTree.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTree.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTreeWidgetAction.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTreeWidgetAction.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTreeWidgetItem.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTreeWidgetItem.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTreeWidgetSelectAction.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/RDFSemanticTreeWidgetSelectAction.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/SemanticStylesheet.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/SemanticStylesheet.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/SemanticStylesheetsEditor.h PRE-CREATION
> /trunk/koffice/libs/main/rdf/SemanticStylesheetsEditor.cpp PRE-CREATION
> /trunk/koffice/libs/main/rdf/SemanticStylesheetsEditor.ui PRE-CREATION
> /trunk/koffice/libs/odf/KoXmlNS.h 1079848
> /trunk/koffice/libs/odf/KoXmlNS.cpp 1079848
> /trunk/koffice/plugins/textshape/CMakeLists.txt 1079848
> /trunk/koffice/plugins/textshape/TextTool.cpp 1079848
> /trunk/koffice/plugins/textshape/commands/TextPasteCommand.cpp 1079848
>
> Diff: http://reviewboard.kde.org/r/2611/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben
>
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic