[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: ToC generation step
From: Jean-Nicolas Artaud <jeannicolasartaud () gmail ! com>
Date: 2010-01-28 9:13:10
Message-ID: 4816864d1001280113o5e709f6dpae97f8bf32bc783 () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2010/1/28 Pierre <pinaraf@pinaraf.info>
> On Thursday 28 January 2010 09:38:45 Thomas Zander wrote:
> > On Thursday 28. January 2010 00.05.20 you wrote:
> > > > Using outline level is not right, items that go into the ToC
> don't
> > > > have to have a number. Also using 'intProperty' looks wrong; use
> > > > hasProperty().
> > >
> > > No, it is the right way, as discussed several times (well, that's what
> I
> > > was said by Jean Nicolas, I couldn't go on IRC when he discussed
> about
> > > this). It's not about having a number, it is about being referenced as
> > > being part of the document structure, the outline.
> >
> > Interesting; I only talked about this with Jean once and that was when he
> > said the outlinelevel method was not possible because of something with
> > defaultoutline level. (I suggested to use styles then)
> Interesting, I believed you had been included in the discussions... :)
>
> > If this has been discussed later, it wasn't with me, but I'm fine with
> you
> > using outline level if you researched it.
> Yes, since default outline level is working now, it will work.
>
> > The point of using hasProperty instead of comparing with zero still
> stands.
> I agree on that.
>
I said yes in a first time, but looking deeper in it, I cannot agree : the
interest here is to know if outlineLevel > 0, it would mean it is not a
standard or normal text. The fact that he has the outline property is not
really necessary (and it is said in the intProperty too). And the number it
self is needed to know how many left spaces are needed.
>
> _______________________________________________
> koffice-devel mailing list
> koffice-devel@kde.org
> https://mail.kde.org/mailman/listinfo/koffice-devel
>
>
[Attachment #5 (text/html)]
<br><br><div class="gmail_quote">2010/1/28 Pierre <span dir="ltr"><<a \
href="mailto:pinaraf@pinaraf.info">pinaraf@pinaraf.info</a>></span><br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Thursday 28 January 2010 09:38:45 \
Thomas Zander wrote:<br> > On Thursday 28. January 2010 00.05.20 you wrote:<br>
> > > Using outline level is not right, items that go into the ToC \
don't<br> > > > have to have a number. Also using 'intProperty' \
looks wrong; use<br> > > > hasProperty().<br>
> ><br>
> > No, it is the right way, as discussed several times (well, that's what \
I<br> > > was said by Jean Nicolas, I couldn't go on IRC when he \
discussed about<br> > > this). It's not about having a number, it is about \
being referenced as<br> > > being part of the document structure, the \
outline.<br> ><br>
> Interesting; I only talked about this with Jean once and that was when he<br>
> said the outlinelevel method was not possible because of something with<br>
> defaultoutline level. (I suggested to use styles then)<br>
</div>Interesting, I believed you had been included in the discussions... :)<br>
<div class="im"><br>
> If this has been discussed later, it wasn't with me, but I'm fine with \
you<br> > using outline level if you researched it.<br>
</div>Yes, since default outline level is working now, it will work.<br>
<div class="im"><br>
> The point of using hasProperty instead of comparing with zero still stands.<br>
</div>I agree on that.<br></blockquote><div>I said yes in a first time, but looking \
deeper in it, I cannot agree : the interest here is to know if outlineLevel > 0, \
it would mean it is not a standard or normal text. The fact that he has the outline \
property is not really necessary (and it is said in the intProperty too). And the \
number it self is needed to know how many left spaces are needed.<br> \
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> \
<br>_______________________________________________<br> koffice-devel mailing \
list<br> <a href="mailto:koffice-devel@kde.org">koffice-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/koffice-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/koffice-devel</a><br> \
<br></blockquote></div><br>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic